* [PATCH] cfg80211: fix unregistration
@ 2009-07-13 11:24 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-07-13 11:24 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless
The work that we cancel there requires the cfg80211_mutex,
so we can't cancel it under the mutex, which is fine, we
can just move it to after the locked section.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/wireless/core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- wireless-testing.orig/net/wireless/core.c 2009-07-13 13:07:44.000000000 +0200
+++ wireless-testing/net/wireless/core.c 2009-07-13 13:08:31.000000000 +0200
@@ -586,11 +586,6 @@ void wiphy_unregister(struct wiphy *wiph
/* unlock again before freeing */
mutex_unlock(&rdev->mtx);
- cancel_work_sync(&rdev->conn_work);
- cancel_work_sync(&rdev->scan_done_wk);
- kfree(rdev->scan_req);
- flush_work(&rdev->event_work);
-
cfg80211_debugfs_rdev_del(rdev);
/* If this device got a regulatory hint tell core its
@@ -602,6 +597,11 @@ void wiphy_unregister(struct wiphy *wiph
debugfs_remove(rdev->wiphy.debugfsdir);
mutex_unlock(&cfg80211_mutex);
+
+ cancel_work_sync(&rdev->conn_work);
+ cancel_work_sync(&rdev->scan_done_wk);
+ kfree(rdev->scan_req);
+ flush_work(&rdev->event_work);
}
EXPORT_SYMBOL(wiphy_unregister);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-13 11:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-13 11:24 [PATCH] cfg80211: fix unregistration Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox