* [PATCH] mac80211_hwsim: fix use after free
@ 2009-07-13 11:25 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-07-13 11:25 UTC (permalink / raw)
To: John Linville; +Cc: Jouni Malinen, linux-wireless
Once the "data" pointer is freed, we can't be iterating
to the next item in the list any more so we need to use
list_for_each_entry_safe with a temporary variable.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/mac80211_hwsim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- wireless-testing.orig/drivers/net/wireless/mac80211_hwsim.c 2009-07-13 13:21:18.000000000 +0200
+++ wireless-testing/drivers/net/wireless/mac80211_hwsim.c 2009-07-13 13:21:42.000000000 +0200
@@ -790,7 +790,7 @@ static const struct ieee80211_ops mac802
static void mac80211_hwsim_free(void)
{
struct list_head tmplist, *i, *tmp;
- struct mac80211_hwsim_data *data;
+ struct mac80211_hwsim_data *data, *tmpdata;
INIT_LIST_HEAD(&tmplist);
@@ -799,7 +799,7 @@ static void mac80211_hwsim_free(void)
list_move(i, &tmplist);
spin_unlock_bh(&hwsim_radio_lock);
- list_for_each_entry(data, &tmplist, list) {
+ list_for_each_entry_safe(data, tmpdata, &tmplist, list) {
debugfs_remove(data->debugfs_group);
debugfs_remove(data->debugfs_ps);
debugfs_remove(data->debugfs);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-13 11:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-13 11:25 [PATCH] mac80211_hwsim: fix use after free Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox