From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
rossi.f@inwind.it
Subject: Re: [PATCH] mac80211: do not trigger beacon loss work if scanning
Date: Fri, 24 Jul 2009 00:59:38 +0200 [thread overview]
Message-ID: <1248389978.10342.1.camel@johannes.local> (raw)
In-Reply-To: <1248389904.10342.0.camel@johannes.local>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Fri, 2009-07-24 at 00:58 +0200, Johannes Berg wrote:
> > @@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned long data)
> > (struct ieee80211_sub_if_data *) data;
> > struct ieee80211_local *local = sdata->local;
> >
> > - if (local->quiescing)
> > + if (local->quiescing || local->sw_scanning || local->hw_scanning)
>
> I'd rather have that check in ieee80211_mgd_probe_ap itself, so it's
> much closer to the source of the problem.
And, incidentally, not racy then.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-07-23 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 22:49 [PATCH] mac80211: do not trigger beacon loss work if scanning Luis R. Rodriguez
2009-07-23 22:58 ` Johannes Berg
2009-07-23 22:59 ` Johannes Berg [this message]
2009-07-23 23:21 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248389978.10342.1.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=rossi.f@inwind.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).