From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
rossi.f@inwind.it
Subject: Re: [PATCH] mac80211: do not trigger beacon loss work if scanning
Date: Thu, 23 Jul 2009 16:21:21 -0700 [thread overview]
Message-ID: <43e72e890907231621l35bc0f82n79b91bd5bda25dcc@mail.gmail.com> (raw)
In-Reply-To: <1248389978.10342.1.camel@johannes.local>
On Thu, Jul 23, 2009 at 3:59 PM, Johannes Berg<johannes@sipsolutions.net> wrote:
> On Fri, 2009-07-24 at 00:58 +0200, Johannes Berg wrote:
>
>> > @@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned long data)
>> > (struct ieee80211_sub_if_data *) data;
>> > struct ieee80211_local *local = sdata->local;
>> >
>> > - if (local->quiescing)
>> > + if (local->quiescing || local->sw_scanning || local->hw_scanning)
>>
>> I'd rather have that check in ieee80211_mgd_probe_ap itself, so it's
>> much closer to the source of the problem.
>
> And, incidentally, not racy then.
And wouldn't it be even better to just disable the timers before
scanning and re-enabling after scanning?
Luis
prev parent reply other threads:[~2009-07-23 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 22:49 [PATCH] mac80211: do not trigger beacon loss work if scanning Luis R. Rodriguez
2009-07-23 22:58 ` Johannes Berg
2009-07-23 22:59 ` Johannes Berg
2009-07-23 23:21 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e890907231621l35bc0f82n79b91bd5bda25dcc@mail.gmail.com \
--to=lrodriguez@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rossi.f@inwind.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox