Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: <linville@tuxdriver.com>
Cc: <linux-wireless@vger.kernel.org>, <ath9k-devel@lists.ath9k.org>,
	<ath5k-devel@lists.ath5k.org>,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: [PATCH 3/3] ath5k: use bit shift operators for cache line size
Date: Wed, 12 Aug 2009 09:57:01 -0700	[thread overview]
Message-ID: <1250096221-11000-4-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1250096221-11000-1-git-send-email-lrodriguez@atheros.com>

This matches ath9k, providing consistency when reading both drivers.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 drivers/net/wireless/ath/ath5k/base.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 63c2b57..2b3cf39 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -471,7 +471,7 @@ ath5k_pci_probe(struct pci_dev *pdev,
 		 * DMA to work so force a reasonable value here if it
 		 * comes up zero.
 		 */
-		csz = L1_CACHE_BYTES / sizeof(u32);
+		csz = L1_CACHE_BYTES >> 2;
 		pci_write_config_byte(pdev, PCI_CACHE_LINE_SIZE, csz);
 	}
 	/*
@@ -544,7 +544,7 @@ ath5k_pci_probe(struct pci_dev *pdev,
 	__set_bit(ATH_STAT_INVALID, sc->status);
 
 	sc->iobase = mem; /* So we can unmap it on detach */
-	sc->common.cachelsz = csz * sizeof(u32); /* convert to bytes */
+	sc->common.cachelsz = csz << 2; /* convert to bytes */
 	sc->opmode = NL80211_IFTYPE_STATION;
 	sc->bintval = 1000;
 	mutex_init(&sc->lock);
-- 
1.6.3.3


  parent reply	other threads:[~2009-08-12 16:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12 16:56 [PATCH 0/3] ath: advance ath.ko with one more helper Luis R. Rodriguez
2009-08-12 16:56 ` [PATCH 1/3] ath: add common ath_rxbuf_alloc() and make ath9k use it Luis R. Rodriguez
2009-08-12 16:57 ` [PATCH 2/3] ath5k: use common ath.ko ath_rxbuf_alloc() Luis R. Rodriguez
2009-08-12 16:57 ` Luis R. Rodriguez [this message]
2009-08-12 17:13   ` [PATCH 3/3] ath5k: use bit shift operators for cache line size Bob Copeland
2009-08-12 17:32     ` Luis R. Rodriguez
2009-08-12 17:50       ` Bob Copeland
2009-08-12 17:21 ` [PATCH 0/3] ath: advance ath.ko with one more helper Bob Copeland
2009-08-12 17:27   ` [ath5k-devel] " Luis R. Rodriguez
2009-08-13  2:13     ` Nick Kossifidis
2009-08-13  2:59       ` Bob Copeland
2009-08-13  3:07       ` Luis R. Rodriguez
2009-08-13 14:41         ` Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250096221-11000-4-git-send-email-lrodriguez@atheros.com \
    --to=lrodriguez@atheros.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox