Re: [ath5k-devel] [PATCH 0/3] ath: advance ath.ko with one more helper

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Wed, Aug 12, 2009 at 10:21 AM, Bob Copeland<me@bobcopeland.com> wrote:
> On Wed, Aug 12, 2009 at 12:56 PM, Luis R.
> Rodriguez<lrodriguez@atheros.com> wrote:
>> This adds a common structure where we can start stuffing shared items
>> and introduces a helper for both ath5k and ath9k's use.
>>
>> Luis R. Rodriguez (3):
>>  ath: add common ath_rxbuf_alloc() and make ath9k use it
>>  ath5k: use common ath.ko ath_rxbuf_alloc()
>>  ath5k: use bit shift operators for cache line size
>
> Series looks OK to me but I think we can add a 4/4 that would:
>
> - include ath/reg.h [don't remember if that's the name right now]
>  in ath.h
> - move reg structs into ath_common (although, this could be a
>  bad call for ar9170, haven't really checked).
>
> Then we only have to deal with one header and one composite struct
> (for now) as the interface between the modules.

Sure, I was thinking of doing this after this. Is that acceptable?

  Luis