From: Johannes Berg <johannes@sipsolutions.net>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Zhu Yi <yi.zhu@intel.com>, Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Rafael Laufer <rlaufer@cs.ucla.edu>,
ipw3945-devel <ipw3945-devel@lists.sourceforge.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: Make injection of non-broadcast frames work again
Date: Fri, 21 Aug 2009 10:21:29 +0200 [thread overview]
Message-ID: <1250842889.13872.8.camel@johannes.local> (raw)
In-Reply-To: <4A8DC955.9060100@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Fri, 2009-08-21 at 00:08 +0200, Gábor Stefanik wrote:
> /* If this frame is broadcast or management, use broadcast station id */
> - if (!ieee80211_is_data(fc) || is_multicast_ether_addr(hdr->addr1))
> + if (!ieee80211_is_data(fc) || is_multicast_ether_addr(hdr->addr1) ||
> + iwl_is_monitor_mode(priv)) /* Injected frames need broadcast too */
> return priv->hw_params.bcast_sta_id;
Now you still can't transmit frames to another AP when connected to one,
which will, for example, be required for 11r. IMHO that code should, in
STATION mode, be checking the RA against the BSSID, and if they match
use the AP ID, otherwise the bcast ID. And remove the warning in the
default case, since that's what happens if in pure monitor mode afaict.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-08-21 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 22:08 [PATCH] iwlwifi: Make injection of non-broadcast frames work again Gábor Stefanik
2009-08-21 8:21 ` Johannes Berg [this message]
2009-08-21 13:21 ` Gábor Stefanik
2009-08-21 13:28 ` Johannes Berg
2009-08-21 16:33 ` reinette chatre
2009-08-21 16:43 ` John W. Linville
2009-08-21 17:24 ` Gábor Stefanik
2009-08-21 17:59 ` reinette chatre
2009-08-21 18:10 ` Gábor Stefanik
2009-08-21 18:24 ` reinette chatre
2009-08-21 18:37 ` Gábor Stefanik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250842889.13872.8.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
--cc=reinette.chatre@intel.com \
--cc=rlaufer@cs.ucla.edu \
--cc=wey-yi.w.guy@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox