From: "Gábor Stefanik" <netrolller.3d@gmail.com>
To: John Linville <linville@tuxdriver.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Zhu Yi <yi.zhu@intel.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Rafael Laufer <rlaufer@cs.ucla.edu>,
ipw3945-devel <ipw3945-devel@lists.sourceforge.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] iwlwifi: Make injection of non-broadcast frames work again
Date: Fri, 21 Aug 2009 00:08:21 +0200 [thread overview]
Message-ID: <4A8DC955.9060100@gmail.com> (raw)
Commit 1ccb84d87d04df3c76cd4352fe69786d8c7cf016 by Wey-Yi Guy
("iwlwifi: clean up unused NL80211_IFTYPE_MONITOR for Monitor mode")
broke injection of non-broadcast frames to unassociated stations
(causing a SYSASSERT for all such injected frames), due to injected
frames no longer automatically getting a broadcast station ID assigned,
and instead ending up with invalid station IDs.
This patch restores the old behavior, fixing the aforementioned
regression.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
This fixes a regression introduced between 2.6.30 and 2.6.31-rc1.
Please apply to 2.6.31.
drivers/net/wireless/iwlwifi/iwl-sta.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
index c6633fe..81a656f 100644
--- a/drivers/net/wireless/iwlwifi/iwl-sta.c
+++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
@@ -1054,7 +1054,8 @@ int iwl_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
__le16 fc = hdr->frame_control;
/* If this frame is broadcast or management, use broadcast station id */
- if (!ieee80211_is_data(fc) || is_multicast_ether_addr(hdr->addr1))
+ if (!ieee80211_is_data(fc) || is_multicast_ether_addr(hdr->addr1) ||
+ iwl_is_monitor_mode(priv)) /* Injected frames need broadcast too */
return priv->hw_params.bcast_sta_id;
switch (priv->iw_mode) {
--
1.6.2.4
next reply other threads:[~2009-08-20 22:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 22:08 Gábor Stefanik [this message]
2009-08-21 8:21 ` [PATCH] iwlwifi: Make injection of non-broadcast frames work again Johannes Berg
2009-08-21 13:21 ` Gábor Stefanik
2009-08-21 13:28 ` Johannes Berg
2009-08-21 16:33 ` reinette chatre
2009-08-21 16:43 ` John W. Linville
2009-08-21 17:24 ` Gábor Stefanik
2009-08-21 17:59 ` reinette chatre
2009-08-21 18:10 ` Gábor Stefanik
2009-08-21 18:24 ` reinette chatre
2009-08-21 18:37 ` Gábor Stefanik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8DC955.9060100@gmail.com \
--to=netrolller.3d@gmail.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=rlaufer@cs.ucla.edu \
--cc=wey-yi.w.guy@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox