Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] iw: fix NL80211_STA_INFO_PLINK_STATE printing in station dump
       [not found] <iw1>
@ 2009-08-27 18:15 ` Brian Cavagnolo
  2009-08-27 18:22   ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Cavagnolo @ 2009-08-27 18:15 UTC (permalink / raw)
  To: johannes; +Cc: linux-wireless, Brian Cavagnolo

NL80211_STA_INFO_PLINK_STATE is a u8, not a u16.  This bug was causing
unexpected output on big endian machines.

Signed-off-by: Brian Cavagnolo <brian@cozybit.com>
---
 station.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/station.c b/station.c
index 0fff92d..a4865f9 100644
--- a/station.c
+++ b/station.c
@@ -127,7 +127,7 @@ static int print_sta_handler(struct nl_msg *msg, void *arg)
 		printf("\n\tmesh plid:\t%d",
 			nla_get_u16(sinfo[NL80211_STA_INFO_PLID]));
 	if (sinfo[NL80211_STA_INFO_PLINK_STATE]) {
-		switch (nla_get_u16(sinfo[NL80211_STA_INFO_PLINK_STATE])) {
+		switch (nla_get_u8(sinfo[NL80211_STA_INFO_PLINK_STATE])) {
 		case LISTEN:
 			strcpy(state_name, "LISTEN");
 			break;
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iw: fix NL80211_STA_INFO_PLINK_STATE printing in station dump
  2009-08-27 18:15 ` [PATCH] iw: fix NL80211_STA_INFO_PLINK_STATE printing in station dump Brian Cavagnolo
@ 2009-08-27 18:22   ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2009-08-27 18:22 UTC (permalink / raw)
  To: Brian Cavagnolo; +Cc: linux-wireless

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

On Thu, 2009-08-27 at 11:15 -0700, Brian Cavagnolo wrote:
> NL80211_STA_INFO_PLINK_STATE is a u8, not a u16.  This bug was causing
> unexpected output on big endian machines.

Applied, thanks.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-27 18:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <iw1>
2009-08-27 18:15 ` [PATCH] iw: fix NL80211_STA_INFO_PLINK_STATE printing in station dump Brian Cavagnolo
2009-08-27 18:22   ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox