From: reinette chatre <reinette.chatre@intel.com>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 07/13] iwlwifi: clean up ht config a little
Date: Fri, 11 Sep 2009 14:12:25 -0700 [thread overview]
Message-ID: <1252703545.26521.143.camel@rc-desk> (raw)
In-Reply-To: <69e28c910909111046m23414728nb9b56c53960340ea@mail.gmail.com>
Hi Gábor,
On Fri, 2009-09-11 at 10:46 -0700, Gábor Stefanik wrote:
> On Fri, Sep 11, 2009 at 7:38 PM, Reinette Chatre
> <reinette.chatre@intel.com> wrote:
> > From: Johannes Berg <johannes@sipsolutions.net>
> >
> > is_ht can be bool instead of u8, and there's
> > no need to use IWL_CHANNEL_WIDTH_* constants
> > in supported_chan_width when that could just
> > be named is_40mhz instead.
>
> What about is_ht40?
It seems that this structure distinguishes explicitly between being ht
(with "is_ht") and the supported channel width (now with "is_40mhz"). To
me it seems a bit awkward to have "is_ht" and "is_ht40". As you can tell
Johannes has been cleaning this up, so maybe he noticed a way in which
this can be clarified.
Reinette
next prev parent reply other threads:[~2009-09-11 21:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 17:38 [PATCH 0/13] iwlwifi driver updates 09/11/2009 Reinette Chatre
2009-09-11 17:38 ` [PATCH 01/13] iwlwifi: modify LED blink index table Reinette Chatre
2009-09-11 17:38 ` [PATCH 02/13 v2.6.32 and w-t] iwlwifi: fix HT operation in 2.4 GHz band Reinette Chatre
2009-09-11 17:38 ` [PATCH 03/13] iwlwifi: remove un-supported eeprom parameters Reinette Chatre
2009-09-11 17:38 ` [PATCH 04/13] iwlwifi: separate nic_config for different NIC Reinette Chatre
2009-09-11 17:38 ` [PATCH 05/13] iwlwifi: separate set_hw_params function for 6000 series Reinette Chatre
2009-09-11 17:38 ` [PATCH 06/13 v2.6.32 and w-t] iwlwifi: fix potential rx buffer loss Reinette Chatre
2009-09-11 17:38 ` [PATCH 07/13] iwlwifi: clean up ht config a little Reinette Chatre
2009-09-11 17:46 ` Gábor Stefanik
2009-09-11 21:12 ` reinette chatre [this message]
2009-09-12 13:12 ` Johannes Berg
2009-09-11 17:38 ` [PATCH 08/13] iwlwifi: Adjust blink rate to compensate Clock difference Reinette Chatre
2009-09-11 17:38 ` [PATCH 09/13] iwlwifi: clean up ht config naming Reinette Chatre
2009-09-13 23:45 ` [ipw3945-devel] " Tomas Winkler
2009-09-13 23:52 ` Johannes Berg
2009-09-11 17:38 ` [PATCH 10/13] iwlwifi: show NVM version in debugfs Reinette Chatre
2009-09-11 17:38 ` [PATCH 11/13] iwlwifi: clarify and clean up chain settings Reinette Chatre
2009-09-11 17:38 ` [PATCH 12/13 v2.6.32 and w-t] iwlwifi: find the correct first antenna Reinette Chatre
2009-09-11 17:38 ` [PATCH 13/13 v2.6.32 and w-t] iwlwifi: disable powersave for 4965 Reinette Chatre
2009-09-11 17:48 ` reinette chatre
2009-09-11 17:50 ` [PATCH 13/13 v2.6.32] " reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252703545.26521.143.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox