BUGLET? cfg80211: .dumpit methods called twice

BUGLET? cfg80211: .dumpit methods called twice

[Holger Schurig]

I just noticed that all functions mentioned on .dumpit in 
net/wireless/nl80211.c are actually called twice.

For example, I've added

--- linux-wl.orig/net/wireless/nl80211.c        2009-09-18 
14:44:28.000000000 +0200
+++ linux-wl/net/wireless/nl80211.c     2009-09-18 
14:45:41.000000000 +0200
@@ -2919,6 +2919,8 @@ static int nl80211_trigger_scan(struct s
        enum ieee80211_band band;
        size_t ie_len;

+       printk("##HS %s:%d\n", __func__, __LINE__);
+
        if (!is_valid_ie_attr(info->attrs[NL80211_ATTR_IE]))
                return -EINVAL;

and when I now issue one "iw eth1 scan dump" I get two logs of 
this printk in my dmesg.

AFAIK it doesn't cause any harm, but it's not that efficient and 
it might cause harm in the future if any of the .dumpit methods 
has the "right" side-effects.

-- 
http://www.holgerschurig.de

Re: BUGLET? cfg80211: .dumpit methods called twice

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

On Tue, 2009-09-22 at 09:33 +0200, Holger Schurig wrote:
> I just noticed that all functions mentioned on .dumpit in 
> net/wireless/nl80211.c are actually called twice.
> 
> For example, I've added
> 
> --- linux-wl.orig/net/wireless/nl80211.c        2009-09-18 
> 14:44:28.000000000 +0200
> +++ linux-wl/net/wireless/nl80211.c     2009-09-18 
> 14:45:41.000000000 +0200
> @@ -2919,6 +2919,8 @@ static int nl80211_trigger_scan(struct s
>         enum ieee80211_band band;
>         size_t ie_len;
> 
> +       printk("##HS %s:%d\n", __func__, __LINE__);
> +
>         if (!is_valid_ie_attr(info->attrs[NL80211_ATTR_IE]))
>                 return -EINVAL;
> 
> and when I now issue one "iw eth1 scan dump" I get two logs of 
> this printk in my dmesg.
> 
> AFAIK it doesn't cause any harm, but it's not that efficient and 
> it might cause harm in the future if any of the .dumpit methods 
> has the "right" side-effects.

Umm, that's expected since dumpit() effectively runs until it returns no
more data.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]