* [PATCH] cfg80211: don't set privacy w/o key
@ 2009-09-24 7:00 Johannes Berg
2009-09-24 9:46 ` Luis R. Rodriguez
2009-09-24 13:36 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Johannes Berg @ 2009-09-24 7:00 UTC (permalink / raw)
To: John Linville; +Cc: Kalle Valo, linux-wireless, Luis R. Rodriguez
When wpa_supplicant is used to connect to open networks,
it causes the wdev->wext.keys to point to key memory, but
that key memory is all empty. Only use privacy when there
is a default key to be used.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
Never happened of course with iw ...
net/wireless/wext-sme.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- wireless-testing.orig/net/wireless/wext-sme.c 2009-09-24 08:51:14.000000000 +0200
+++ wireless-testing/net/wireless/wext-sme.c 2009-09-24 08:57:01.000000000 +0200
@@ -30,7 +30,8 @@ int cfg80211_mgd_wext_connect(struct cfg
if (wdev->wext.keys) {
wdev->wext.keys->def = wdev->wext.default_key;
wdev->wext.keys->defmgmt = wdev->wext.default_mgmt_key;
- wdev->wext.connect.privacy = true;
+ if (wdev->wext.default_key != -1)
+ wdev->wext.connect.privacy = true;
}
if (!wdev->wext.connect.ssid_len)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cfg80211: don't set privacy w/o key
2009-09-24 7:00 [PATCH] cfg80211: don't set privacy w/o key Johannes Berg
@ 2009-09-24 9:46 ` Luis R. Rodriguez
2009-09-24 13:36 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2009-09-24 9:46 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, Kalle Valo, linux-wireless
On Thu, Sep 24, 2009 at 12:00 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> When wpa_supplicant is used to connect to open networks,
> it causes the wdev->wext.keys to point to key memory, but
> that key memory is all empty. Only use privacy when there
> is a default key to be used.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Tested-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cfg80211: don't set privacy w/o key
2009-09-24 7:00 [PATCH] cfg80211: don't set privacy w/o key Johannes Berg
2009-09-24 9:46 ` Luis R. Rodriguez
@ 2009-09-24 13:36 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2009-09-24 13:36 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless, Luis R. Rodriguez
On Thu, Sep 24, 2009 at 12:00 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> When wpa_supplicant is used to connect to open networks,
> it causes the wdev->wext.keys to point to key memory, but
> that key memory is all empty. Only use privacy when there
> is a default key to be used.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Thanks, this fixes the issue I reported yesterday evening.
Tested-by: Kalle Valo <kalle.valo@iki.fi>
> Never happened of course with iw ...
This is just the reason why I still use stock wpa_supplicant from debian :)
Kalle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-24 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-24 7:00 [PATCH] cfg80211: don't set privacy w/o key Johannes Berg
2009-09-24 9:46 ` Luis R. Rodriguez
2009-09-24 13:36 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox