Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] cfg80211: always get BSS
@ 2009-09-26 12:42 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-09-26 12:42 UTC (permalink / raw)
  To: John Linville; +Cc: Hin-Tak Leung, linux-wireless

Multiple problems were reported due to interaction
between wpa_supplicant and the wext compat code in
cfg80211, which appear to be due to it not getting
any bss pointer here when wpa_supplicant sets all
parameters -- do that now. We should still get the
bss after doing an extra scan, but that appears to
increase the time we need for connecting enough to
sometimes cause timeouts.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Tested-by: Hin-Tak Leung <hintak.leung@gmail.com>,
---
 net/wireless/sme.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- wireless-testing.orig/net/wireless/sme.c	2009-09-26 14:35:34.000000000 +0200
+++ wireless-testing/net/wireless/sme.c	2009-09-26 14:35:37.000000000 +0200
@@ -762,9 +762,8 @@ int __cfg80211_connect(struct cfg80211_r
 		wdev->conn->params.ssid = wdev->ssid;
 		wdev->conn->params.ssid_len = connect->ssid_len;
 
-		/* don't care about result -- but fill bssid & channel */
-		if (!wdev->conn->params.bssid || !wdev->conn->params.channel)
-			bss = cfg80211_get_conn_bss(wdev);
+		/* see if we have the bss already */
+		bss = cfg80211_get_conn_bss(wdev);
 
 		wdev->sme_state = CFG80211_SME_CONNECTING;
 		wdev->connect_keys = connkeys;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-09-26 12:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-26 12:42 [PATCH] cfg80211: always get BSS Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox