* [PATCH] mac80211: remove bogus code
@ 2009-09-29 22:03 Johannes Berg
2009-10-30 14:48 ` [PATCH resend] " Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-09-29 22:03 UTC (permalink / raw)
To: John Linville; +Cc: Jouni Malinen, linux-wireless
It's not right to do something here when returning an
error, and hostapd should never have relied on it as
it only fixes up a small part of the problem anyway.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/cfg.c | 7 -------
1 file changed, 7 deletions(-)
--- wireless-testing.orig/net/mac80211/cfg.c 2009-09-30 00:00:37.000000000 +0200
+++ wireless-testing/net/mac80211/cfg.c 2009-09-30 00:00:48.000000000 +0200
@@ -738,13 +738,6 @@ static int ieee80211_add_station(struct
err = sta_info_insert(sta);
if (err) {
- /* STA has been freed */
- if (err == -EEXIST && layer2_update) {
- /* Need to update layer 2 devices on reassociation */
- sta = sta_info_get(local, mac);
- if (sta)
- ieee80211_send_layer2_update(sta);
- }
rcu_read_unlock();
return err;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH resend] mac80211: remove bogus code
2009-09-29 22:03 [PATCH] mac80211: remove bogus code Johannes Berg
@ 2009-10-30 14:48 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2009-10-30 14:48 UTC (permalink / raw)
To: John Linville; +Cc: Jouni Malinen, linux-wireless
It's not right to do something here when returning an
error, and hostapd should never have relied on it as
it only fixes up a small part of the problem anyway.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/cfg.c | 7 -------
1 file changed, 7 deletions(-)
--- wireless-testing.orig/net/mac80211/cfg.c 2009-10-27 09:06:22.000000000 +0100
+++ wireless-testing/net/mac80211/cfg.c 2009-10-27 09:42:05.000000000 +0100
@@ -738,13 +738,6 @@ static int ieee80211_add_station(struct
err = sta_info_insert(sta);
if (err) {
- /* STA has been freed */
- if (err == -EEXIST && layer2_update) {
- /* Need to update layer 2 devices on reassociation */
- sta = sta_info_get(local, mac);
- if (sta)
- ieee80211_send_layer2_update(sta);
- }
rcu_read_unlock();
return err;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-30 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-29 22:03 [PATCH] mac80211: remove bogus code Johannes Berg
2009-10-30 14:48 ` [PATCH resend] " Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox