From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Jouni Malinen <j@w1.fi>,
"hostap@lists.shmoo.com" <hostap@lists.shmoo.com>
Subject: Re: driver_nl80211 broken again
Date: Wed, 30 Sep 2009 03:19:28 +0200 [thread overview]
Message-ID: <1254273569.4499.8.camel@maxim-laptop> (raw)
In-Reply-To: <1252443260.16422.5.camel@maxim-laptop>
>
> Sure!
> Very soon will do
>
So I didn't do the testing that soon...
Got swamped by many bugs present in ubuntu 9.10.
Now I have attempted same patch on top of wpa_supplicant, and it works.
diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
index 37a1927..a0098b9 100644
--- a/wpa_supplicant/wpa_supplicant.c
+++ b/wpa_supplicant/wpa_supplicant.c
@@ -1302,8 +1302,10 @@ void wpa_supplicant_disassociate(struct wpa_supplicant *wpa_s,
if (!is_zero_ether_addr(wpa_s->bssid)) {
if (wpa_s->drv_flags & WPA_DRIVER_FLAGS_USER_SPACE_MLME)
ieee80211_sta_disassociate(wpa_s, reason_code);
- else
+ else {
wpa_drv_disassociate(wpa_s, wpa_s->bssid, reason_code);
+ wpa_drv_deauthenticate(wpa_s, wpa_s->bssid, reason_code);
+ }
addr = wpa_s->bssid;
}
wpa_clear_keys(wpa_s, addr);
Would that be enough, or this is too hacky, and we need to audit each callsite of wpa_supplicant_disassociate
and see if we need to send deauth frame too?
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2009-09-30 1:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 12:32 driver_nl80211 broken again Maxim Levitsky
2009-08-24 14:08 ` Johannes Berg
2009-08-24 20:06 ` Maxim Levitsky
2009-08-24 20:58 ` Johannes Berg
2009-09-05 2:08 ` Maxim Levitsky
2009-09-05 13:07 ` Johannes Berg
2009-09-08 15:29 ` Johannes Berg
2009-09-08 20:54 ` Maxim Levitsky
2009-09-30 1:19 ` Maxim Levitsky [this message]
2009-09-30 22:13 ` Jouni Malinen
2009-10-01 8:46 ` Johannes Berg
2009-10-02 21:31 ` Trepak Vilmos
2009-10-03 5:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254273569.4499.8.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=hostap@lists.shmoo.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox