BUG: "wext: refactor" broke compilation

BUG: "wext: refactor" broke compilation

[Holger Schurig]

  LD      net/wireless/built-in.o
  CC [M]  net/wireless/core.o
net/wireless/core.c: In function 'cfg80211_netdev_notifier_call':
net/wireless/core.c:673: error: 'struct wireless_dev' has no member named 'wext'
net/wireless/core.c:674: error: 'struct wireless_dev' has no member named 'wext'
net/wireless/core.c:675: error: 'struct wireless_dev' has no member named 'wext'
net/wireless/core.c:676: error: 'struct wireless_dev' has no member named 'wext'
net/wireless/core.c:677: error: 'struct wireless_dev' has no member named 'wext'
net/wireless/core.c:680: error: 'struct wireless_dev' has no member named 'wext'
net/wireless/core.c:681: error: 'struct wireless_dev' has no member named 'wext'
net/wireless/core.c:683: error: 'struct wireless_dev' has no member named 'wext'

The reason is that currently two different Kconfig
defines are used:


in net/wireless/core.c:

#ifdef CONFIG_WIRELESS_EXT
                wdev->wext.default_key = -1;
  ...
#endif


in include/net/cfg80211.h:

#ifdef CONFIG_CFG80211_WEXT
        /* wext data */
        struct {
  ...
        } wext;
#endif


But I configure my kernel this way:

$ grep WIRELESS .config
CONFIG_WIRELESS=y
CONFIG_WIRELESS_EXT=y
...

$ grep WEXT .config
CONFIG_WEXT_CORE=y
CONFIG_WEXT_PROC=y
CONFIG_WEXT_SPY=y
CONFIG_WEXT_PRIV=y
# CONFIG_CFG80211_WEXT is not set

-- 
http://www.holgerschurig.de

Re: BUG: "wext: refactor" broke compilation

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

On Thu, 2009-10-01 at 11:39 +0200, Holger Schurig wrote:
> LD      net/wireless/built-in.o
>   CC [M]  net/wireless/core.o
> net/wireless/core.c: In function 'cfg80211_netdev_notifier_call':
> net/wireless/core.c:673: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:674: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:675: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:676: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:677: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:680: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:681: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:683: error: 'struct wireless_dev' has no member named 'wext'
> 
> The reason is that currently two different Kconfig
> defines are used:
> 
> 
> in net/wireless/core.c:
> 
> #ifdef CONFIG_WIRELESS_EXT
>                 wdev->wext.default_key = -1;
>   ...
> #endif

Oops, yes, that one needs to be fixed. I thought I just used sed but I
guess somehow I managed to miss this one.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: BUG: "wext: refactor" broke compilation

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

On Thu, 2009-10-01 at 11:39 +0200, Holger Schurig wrote:
> LD      net/wireless/built-in.o
>   CC [M]  net/wireless/core.o
> net/wireless/core.c: In function 'cfg80211_netdev_notifier_call':
> net/wireless/core.c:673: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:674: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:675: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:676: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:677: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:680: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:681: error: 'struct wireless_dev' has no member named 'wext'
> net/wireless/core.c:683: error: 'struct wireless_dev' has no member named 'wext'
> 
> The reason is that currently two different Kconfig
> defines are used:
> 
> 
> in net/wireless/core.c:
> 
> #ifdef CONFIG_WIRELESS_EXT
>                 wdev->wext.default_key = -1;
>   ...
> #endif

Did you send a patch to change that to CONFIG_CFG80211_WEXT, or do I
need to?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: BUG: "wext: refactor" broke compilation

[Holger Schurig]

> Did you send a patch to change that to CONFIG_CFG80211_WEXT, or do I
> need to?

No, I had to go to a customer (I'm "jack-in-all-trades"), so
I didn't have time.

-- 
http://www.holgerschurig.de