* [PATCH] cfg80211: remove warning in deauth case
@ 2009-10-13 11:45 Holger Schurig
2009-10-16 9:32 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Holger Schurig @ 2009-10-13 11:45 UTC (permalink / raw)
To: linux-wireless, John W. Linville; +Cc: Johannes Berg
It might be the case that __cfg80211_disconnected() has already
cleaned up wdev->current_bss() for us. The old code didn't catch
that situation and didn't warn needlessly.
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
---
For more info, see mail "cfg80211 / libertas: an unusual race"
in the linux-wireless mailing list.
--- linux-wl.orig/net/wireless/mlme.c
+++ linux-wl/net/wireless/mlme.c
@@ -130,7 +130,6 @@
struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)buf;
const u8 *bssid = mgmt->bssid;
int i;
- bool done = false;
ASSERT_WDEV_LOCK(wdev);
@@ -138,7 +137,6 @@
if (wdev->current_bss &&
memcmp(wdev->current_bss->pub.bssid, bssid, ETH_ALEN) == 0) {
- done = true;
cfg80211_unhold_bss(wdev->current_bss);
cfg80211_put_bss(&wdev->current_bss->pub);
wdev->current_bss = NULL;
@@ -148,7 +146,6 @@
cfg80211_unhold_bss(wdev->auth_bsses[i]);
cfg80211_put_bss(&wdev->auth_bsses[i]->pub);
wdev->auth_bsses[i] = NULL;
- done = true;
break;
}
if (wdev->authtry_bsses[i] &&
@@ -156,13 +153,10 @@
cfg80211_unhold_bss(wdev->authtry_bsses[i]);
cfg80211_put_bss(&wdev->authtry_bsses[i]->pub);
wdev->authtry_bsses[i] = NULL;
- done = true;
break;
}
}
- WARN_ON(!done);
-
if (wdev->sme_state == CFG80211_SME_CONNECTED) {
u16 reason_code;
bool from_ap;
--
http://www.holgerschurig.de
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cfg80211: remove warning in deauth case
2009-10-13 11:45 [PATCH] cfg80211: remove warning in deauth case Holger Schurig
@ 2009-10-16 9:32 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2009-10-16 9:32 UTC (permalink / raw)
To: Holger Schurig; +Cc: linux-wireless, John W. Linville
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On Tue, 2009-10-13 at 13:45 +0200, Holger Schurig wrote:
> It might be the case that __cfg80211_disconnected() has already
> cleaned up wdev->current_bss() for us. The old code didn't catch
> that situation and didn't warn needlessly.
Care to explain how that can happen?
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
>
> ---
>
> For more info, see mail "cfg80211 / libertas: an unusual race"
> in the linux-wireless mailing list.
Oh ok, I suppose that explains it?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-16 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-13 11:45 [PATCH] cfg80211: remove warning in deauth case Holger Schurig
2009-10-16 9:32 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox