public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Greg KH <gregkh@suse.de>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ming Lei <tom.leiming@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Pavel Roskin <proski@gnu.org>,
	Abhay Salunke <abhay_salunke@dell.com>
Subject: Re: [PATCH] firmware_class: make request_firmware_nowait more useful
Date: Thu, 29 Oct 2009 22:58:12 +0900	[thread overview]
Message-ID: <1256824692.5768.41.camel@localhost.localdomain> (raw)
In-Reply-To: <1256816162.3865.110.camel@johannes.local>

Hi Johannes,

> Unfortunately, one cannot hold on to the struct firmware
> that request_firmware_nowait() hands off, which is needed
> in some cases. Allow this by requiring the callback to
> free it (via release_firmware).
> 
> Additionally, give it a gfp_t parameter -- all the current
> users call it from a GFP_KERNEL context so the GFP_ATOMIC
> isn't necessary. This also marks an API break which is
> useful in a sense, although that is obviously not the
> primary purpose of this change.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

I had a look at this one and looks good to me and makes perfect sense.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



      reply	other threads:[~2009-10-29 13:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29 11:36 [PATCH] firmware_class: make request_firmware_nowait more useful Johannes Berg
2009-10-29 13:58 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256824692.5768.41.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=David.Woodhouse@intel.com \
    --cc=abhay_salunke@dell.com \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@suse.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=proski@gnu.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox