From: Johannes Berg <johannes@sipsolutions.net>
To: gregor kowski <gregor.kowski@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211 : fix a race with update_tkip_key
Date: Sat, 07 Nov 2009 20:22:37 +0100 [thread overview]
Message-ID: <1257621757.29454.48.camel@johannes.local> (raw)
In-Reply-To: <83a869cd0911071010g32c798c6pfecd875a1bf484e0@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Sat, 2009-11-07 at 19:10 +0100, gregor kowski wrote:
> >> +enum ieee80211_internal_tkip_initialized {
> >> + TKIP_INITIALIZED_NONE,
> >> + TKIP_INITIALIZED_PHASE1,
> >> + TKIP_INITIALIZED_UPDATE_KEY,
> >> +};
> >
> > Those constants and the enum itself really need better names. This way,
> > there's no way to understand what it means without reading all the code.
> >
> Could you suggest better name ?
>
> ieee80211_internal_tkip_state and
> TKIP_STATE_NOT_INIT
> TKIP_STATE_PHASE1_DONE
> TKIP_STATE_PHASE1_HW_UPLOADED
I, eh, ... have no idea :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-11-07 19:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 22:13 [PATCH] mac80211 : fix a race with update_tkip_key gregor kowski
2009-08-22 7:45 ` Johannes Berg
2009-11-07 18:10 ` gregor kowski
2009-11-07 19:22 ` Johannes Berg [this message]
2009-11-16 21:53 ` gregor kowski
2009-11-16 21:56 ` Johannes Berg
2009-12-07 21:05 ` gregor kowski
2009-12-07 21:06 ` gregor kowski
2009-12-09 22:21 ` gregor kowski
2009-12-09 22:25 ` gregor kowski
2009-12-28 16:46 ` gregor kowski
2009-12-28 17:23 ` John W. Linville
[not found] <83a869cd0906071445i13a5398y5e94ea3d91123c3b@mail.gmail.com>
2009-06-07 21:49 ` gregor kowski
2009-06-08 6:29 ` Johannes Berg
2009-06-08 17:51 ` gregor kowski
2009-06-09 14:02 ` Johannes Berg
2009-06-09 17:48 ` gregor kowski
2009-06-09 17:52 ` Johannes Berg
2009-06-10 19:42 ` gregor kowski
2009-06-10 22:17 ` gregor kowski
2009-06-11 20:11 ` Johannes Berg
2009-06-11 20:07 ` Johannes Berg
2009-06-12 20:41 ` gregor kowski
2009-06-12 20:47 ` Johannes Berg
2009-06-19 19:33 ` gregor kowski
2009-06-19 19:37 ` gregor kowski
2009-06-21 9:21 ` Johannes Berg
2009-06-22 20:48 ` gregor kowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257621757.29454.48.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=gregor.kowski@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox