From: gregor kowski <gregor.kowski@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211 : fix a race with update_tkip_key
Date: Mon, 22 Jun 2009 22:48:42 +0200 [thread overview]
Message-ID: <83a869cd0906221348k4ed42ccbr6721c8bb020c4de5@mail.gmail.com> (raw)
In-Reply-To: <1245576079.16399.31.camel@johannes.local>
Race could happen with QOS :
let's consider queue 0 low prio and queue 1 high prio
- queue 1 send packet lot's of packet (iv32 = 0, iv32=1, iv32=2)
- queue 0 send a packet with iv32=1 and iv16=0xffff (or near wrap)
If queue 0 packet with iv32=1 is received after queue 1 with iv32=2, we will
- send tkip key for iv32=2 to hardware
- send tkip key for iv32=1 to hardware
and then we should wait wrap to iv32=3 to have a chance to send
correct key to hardware.
With this patch, we only send tkip key to hardware on the first wrap of a queue.
With the previous example, we will only send tkip key for iv32=2 to hardware.
Gregor
next prev parent reply other threads:[~2009-06-22 20:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83a869cd0906071445i13a5398y5e94ea3d91123c3b@mail.gmail.com>
2009-06-07 21:49 ` [PATCH] mac80211 : fix a race with update_tkip_key gregor kowski
2009-06-08 6:29 ` Johannes Berg
2009-06-08 17:51 ` gregor kowski
2009-06-09 14:02 ` Johannes Berg
2009-06-09 17:48 ` gregor kowski
2009-06-09 17:52 ` Johannes Berg
2009-06-10 19:42 ` gregor kowski
2009-06-10 22:17 ` gregor kowski
2009-06-11 20:11 ` Johannes Berg
2009-06-11 20:07 ` Johannes Berg
2009-06-12 20:41 ` gregor kowski
2009-06-12 20:47 ` Johannes Berg
2009-06-19 19:33 ` gregor kowski
2009-06-19 19:37 ` gregor kowski
2009-06-21 9:21 ` Johannes Berg
2009-06-22 20:48 ` gregor kowski [this message]
2009-08-21 22:13 gregor kowski
2009-08-22 7:45 ` Johannes Berg
2009-11-07 18:10 ` gregor kowski
2009-11-07 19:22 ` Johannes Berg
2009-11-16 21:53 ` gregor kowski
2009-11-16 21:56 ` Johannes Berg
2009-12-07 21:05 ` gregor kowski
2009-12-07 21:06 ` gregor kowski
2009-12-09 22:21 ` gregor kowski
2009-12-09 22:25 ` gregor kowski
2009-12-28 16:46 ` gregor kowski
2009-12-28 17:23 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a869cd0906221348k4ed42ccbr6721c8bb020c4de5@mail.gmail.com \
--to=gregor.kowski@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox