public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net,
	Johannes Berg <johannes@sipsolutions.net>,
	Reinette Chatre <reinette.chatre@intel.com>
Subject: [PATCH 13/16] iwlwifi: report PS filtered status
Date: Fri, 13 Nov 2009 11:56:35 -0800	[thread overview]
Message-ID: <1258142198-3223-14-git-send-email-reinette.chatre@intel.com> (raw)
In-Reply-To: <1258142198-3223-1-git-send-email-reinette.chatre@intel.com>

From: Johannes Berg <johannes@sipsolutions.net>

When a frame is sent to a sleeping station, the
microcode reports TX_STATUS_FAIL_DEST_PS as its
status -- we need to translate that to the flag
that mac80211 expects.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
---
 drivers/net/wireless/iwlwifi/iwl-4965.c     |    6 ++----
 drivers/net/wireless/iwlwifi/iwl-5000.c     |    6 ++----
 drivers/net/wireless/iwlwifi/iwl-commands.h |   15 +++++++++++++++
 3 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
index cc39424..39e7244 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -1865,8 +1865,7 @@ static int iwl4965_tx_status_reply_tx(struct iwl_priv *priv,
 		info = IEEE80211_SKB_CB(priv->txq[txq_id].txb[idx].skb[0]);
 		info->status.rates[0].count = tx_resp->failure_frame + 1;
 		info->flags &= ~IEEE80211_TX_CTL_AMPDU;
-		info->flags |= iwl_is_tx_success(status) ?
-			IEEE80211_TX_STAT_ACK : 0;
+		info->flags |= iwl_tx_status_to_mac80211(status);
 		iwl_hwrate_to_tx_control(priv, rate_n_flags, info);
 		/* FIXME: code repetition end */
 
@@ -2021,8 +2020,7 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv,
 		}
 	} else {
 		info->status.rates[0].count = tx_resp->failure_frame + 1;
-		info->flags |= iwl_is_tx_success(status) ?
-					IEEE80211_TX_STAT_ACK : 0;
+		info->flags |= iwl_tx_status_to_mac80211(status);
 		iwl_hwrate_to_tx_control(priv,
 					le32_to_cpu(tx_resp->rate_n_flags),
 					info);
diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c
index 60b1a7e..30b1d66 100644
--- a/drivers/net/wireless/iwlwifi/iwl-5000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
@@ -994,8 +994,7 @@ static int iwl5000_tx_status_reply_tx(struct iwl_priv *priv,
 		info = IEEE80211_SKB_CB(priv->txq[txq_id].txb[idx].skb[0]);
 		info->status.rates[0].count = tx_resp->failure_frame + 1;
 		info->flags &= ~IEEE80211_TX_CTL_AMPDU;
-		info->flags |= iwl_is_tx_success(status) ?
-					IEEE80211_TX_STAT_ACK : 0;
+		info->flags |= iwl_tx_status_to_mac80211(status);
 		iwl_hwrate_to_tx_control(priv, rate_n_flags, info);
 
 		/* FIXME: code repetition end */
@@ -1140,8 +1139,7 @@ static void iwl5000_rx_reply_tx(struct iwl_priv *priv,
 		BUG_ON(txq_id != txq->swq_id);
 
 		info->status.rates[0].count = tx_resp->failure_frame + 1;
-		info->flags |= iwl_is_tx_success(status) ?
-					IEEE80211_TX_STAT_ACK : 0;
+		info->flags |= iwl_tx_status_to_mac80211(status);
 		iwl_hwrate_to_tx_control(priv,
 					le32_to_cpu(tx_resp->rate_n_flags),
 					info);
diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h b/drivers/net/wireless/iwlwifi/iwl-commands.h
index 6e23a2b..87a7f28 100644
--- a/drivers/net/wireless/iwlwifi/iwl-commands.h
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h
@@ -1690,6 +1690,21 @@ enum {
 	TX_ABORT_REQUIRED_MSK = 0x80000000,	/* bits 31:31 */
 };
 
+static inline u32 iwl_tx_status_to_mac80211(u32 status)
+{
+	status &= TX_STATUS_MSK;
+
+	switch (status) {
+	case TX_STATUS_SUCCESS:
+	case TX_STATUS_DIRECT_DONE:
+		return IEEE80211_TX_STAT_ACK;
+	case TX_STATUS_FAIL_DEST_PS:
+		return IEEE80211_TX_STAT_TX_FILTERED;
+	default:
+		return 0;
+	}
+}
+
 static inline bool iwl_is_tx_success(u32 status)
 {
 	status &= TX_STATUS_MSK;
-- 
1.5.6.3


  parent reply	other threads:[~2009-11-13 19:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 19:56 [PATCH 00/16] iwlwifi updates 11/13/2009 Reinette Chatre
2009-11-13 19:56 ` [PATCH 01/16] iwlwifi: validate enhanced tx power entry Reinette Chatre
2009-11-13 19:56 ` [PATCH 02/16] iwlwifi: disable coex until implementation ready for 6x50 Reinette Chatre
2009-11-13 19:56 ` [PATCH 03/16] iwlwifi: remove unused parameter from iwl_channel_info Reinette Chatre
2009-11-13 19:56 ` [PATCH 04/16] iwlwifi: drop non-production PCI-IDs for 6x50 series Reinette Chatre
2009-11-14 15:26   ` Gábor Stefanik
2009-11-16 14:24     ` Guy, Wey-Yi
2009-11-13 19:56 ` [PATCH 05/16] iwlwifi: remove external reference for non-exist data structure Reinette Chatre
2009-11-13 19:56 ` [PATCH 06/16] iwlwifi: update reply_statistics_cmd with 'clear' parameter Reinette Chatre
2009-11-13 19:56 ` [PATCH 07/16] iwl3945: Reset saved POWER_TABLE_CMD in "up" Reinette Chatre
2009-11-13 19:56 ` [PATCH 08/16] iwlwifi: eliminate the possible 1/2 dBm tx power loss in 6x00 & 6x50 series Reinette Chatre
2009-11-13 19:56 ` [PATCH 09/16] iwlwifi: align tx/rx statistics debugfs format Reinette Chatre
2009-11-13 19:56 ` [PATCH 10/16] iwlagn: power up device before initializing EEPROM Reinette Chatre
2009-11-13 19:56 ` [PATCH 11/16] iwlwifi: fix bugs in beacon configuration Reinette Chatre
2009-11-13 19:56 ` [PATCH 12/16] iwlwifi: make iwlwifi send beacons Reinette Chatre
2009-11-13 19:56 ` Reinette Chatre [this message]
2009-11-13 19:56 ` [PATCH 14/16] iwlwifi: add sleep_tx_count ucode station API Reinette Chatre
2009-11-13 19:56 ` [PATCH 15/16] iwlwifi: handle unicast PS buffering Reinette Chatre
2009-11-13 22:14   ` Maxim Levitsky
2009-11-13 22:20     ` Johannes Berg
2009-11-18 23:34       ` Maxim Levitsky
2009-11-18 23:46         ` Johannes Berg
2009-11-13 19:56 ` [PATCH 16/16] iwlwifi: Add comments about CSR registers Reinette Chatre
2009-11-13 20:12 ` [PATCH 00/16] iwlwifi updates 11/13/2009 Luis R. Rodriguez
2009-11-13 20:41   ` reinette chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258142198-3223-14-git-send-email-reinette.chatre@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox