public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 15/16] iwlwifi: handle unicast PS buffering
Date: Sat, 14 Nov 2009 00:14:51 +0200	[thread overview]
Message-ID: <1258150491.4182.6.camel@maxim-laptop> (raw)
In-Reply-To: <1258142198-3223-16-git-send-email-reinette.chatre@intel.com>

On Fri, 2009-11-13 at 11:56 -0800, Reinette Chatre wrote: 
> From: Johannes Berg <johannes@sipsolutions.net>
> 
> Using the new mac80211 functionality, this makes
> iwlwifi handle unicast PS buffering correctly.
> The device works like this:
> 
>  * when a station goes to sleep, the microcode notices
>    this and marks the station as asleep
>  * when the station is marked asleep, the microcode
>    refuses to transmit to the station and rejects all
>    frames queued to it with the failure status code
>    TX_STATUS_FAIL_DEST_PS (a previous patch handled
>    this correctly)
>  * when we need to send frames to the station _although_
>    it is asleep, we need to tell the ucode how many,
>    and this is asynchronous with sending so we cannot
>    just send the frames, we need to wait for all other
>    frames to be flushed, and then update the counter
>    before sending out the poll response frames. This
>    is handled partially in the driver and partially in
>    mac80211.
> 
> In order to do all this correctly, we need to
>  * keep track of how many frames are pending for each
>    associated client station (avoid doing it for other
>    stations to avoid the atomic ops)
>  * tell mac80211 that we driver-block the PS status
>    while there are still frames pending on the queues,
>    and once they are all rejected (due to the dest sta
>    being in PS) unblock mac80211

Does this cover iwl3945?
If so, AP mode would be possible?

Best regards,
Maxim Levitsky




  reply	other threads:[~2009-11-13 22:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 19:56 [PATCH 00/16] iwlwifi updates 11/13/2009 Reinette Chatre
2009-11-13 19:56 ` [PATCH 01/16] iwlwifi: validate enhanced tx power entry Reinette Chatre
2009-11-13 19:56 ` [PATCH 02/16] iwlwifi: disable coex until implementation ready for 6x50 Reinette Chatre
2009-11-13 19:56 ` [PATCH 03/16] iwlwifi: remove unused parameter from iwl_channel_info Reinette Chatre
2009-11-13 19:56 ` [PATCH 04/16] iwlwifi: drop non-production PCI-IDs for 6x50 series Reinette Chatre
2009-11-14 15:26   ` Gábor Stefanik
2009-11-16 14:24     ` Guy, Wey-Yi
2009-11-13 19:56 ` [PATCH 05/16] iwlwifi: remove external reference for non-exist data structure Reinette Chatre
2009-11-13 19:56 ` [PATCH 06/16] iwlwifi: update reply_statistics_cmd with 'clear' parameter Reinette Chatre
2009-11-13 19:56 ` [PATCH 07/16] iwl3945: Reset saved POWER_TABLE_CMD in "up" Reinette Chatre
2009-11-13 19:56 ` [PATCH 08/16] iwlwifi: eliminate the possible 1/2 dBm tx power loss in 6x00 & 6x50 series Reinette Chatre
2009-11-13 19:56 ` [PATCH 09/16] iwlwifi: align tx/rx statistics debugfs format Reinette Chatre
2009-11-13 19:56 ` [PATCH 10/16] iwlagn: power up device before initializing EEPROM Reinette Chatre
2009-11-13 19:56 ` [PATCH 11/16] iwlwifi: fix bugs in beacon configuration Reinette Chatre
2009-11-13 19:56 ` [PATCH 12/16] iwlwifi: make iwlwifi send beacons Reinette Chatre
2009-11-13 19:56 ` [PATCH 13/16] iwlwifi: report PS filtered status Reinette Chatre
2009-11-13 19:56 ` [PATCH 14/16] iwlwifi: add sleep_tx_count ucode station API Reinette Chatre
2009-11-13 19:56 ` [PATCH 15/16] iwlwifi: handle unicast PS buffering Reinette Chatre
2009-11-13 22:14   ` Maxim Levitsky [this message]
2009-11-13 22:20     ` Johannes Berg
2009-11-18 23:34       ` Maxim Levitsky
2009-11-18 23:46         ` Johannes Berg
2009-11-13 19:56 ` [PATCH 16/16] iwlwifi: Add comments about CSR registers Reinette Chatre
2009-11-13 20:12 ` [PATCH 00/16] iwlwifi updates 11/13/2009 Luis R. Rodriguez
2009-11-13 20:41   ` reinette chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258150491.4182.6.camel@maxim-laptop \
    --to=maximlevitsky@gmail.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox