[PATCH 2/2] Adding kerneldoc entry for radio type GPS

[PATCH 2/2] Adding kerneldoc entry for radio type GPS

[janakiram.sistla]

From: Janakiram Sistla <janakiram.sistla@gmail.com>


Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
 include/linux/rfkill.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index d787d5f..212f555 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -36,6 +36,7 @@
  * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
  * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
  * @RFKILL_TYPE_FM: switch is on a FM device.
+ * @RFKILL_TYPE_GPS: switch is on a GPS device.
  * @NUM_RFKILL_TYPES: number of defined rfkill types
  */
 enum rfkill_type {
-- 
1.5.4.3

Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS

[Marcel Holtmann]

Hi guys,

> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> 
> 
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
>  include/linux/rfkill.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index d787d5f..212f555 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -36,6 +36,7 @@
>   * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>   * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>   * @RFKILL_TYPE_FM: switch is on a FM device.
> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>   * @NUM_RFKILL_TYPES: number of defined rfkill types
>   */
>  enum rfkill_type {

so this is getting stupid right now. I am sick of a really simple patch
causes so much trouble. Even this one is wrong again. The GPS doc should
obviously before FM.

Regards

Marcel

Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS

[Janakiram Sistla]

On Wed, Nov 18, 2009 at 9:05 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi guys,
>
>> From: Janakiram Sistla <janakiram.sistla@gmail.com>
>>
>>
>> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
>> ---
>>  include/linux/rfkill.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> index d787d5f..212f555 100644
>> --- a/include/linux/rfkill.h
>> +++ b/include/linux/rfkill.h
>> @@ -36,6 +36,7 @@
>>   * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>>   * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>>   * @RFKILL_TYPE_FM: switch is on a FM device.
>> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>>   * @NUM_RFKILL_TYPES: number of defined rfkill types
>>   */
>>  enum rfkill_type {
>
> so this is getting stupid right now. I am sick of a really simple patch
> causes so much trouble. Even this one is wrong again. The GPS doc should
> obviously before FM.
Marcel I think you want me to submit GPS doc patch first.I will be
doing it shortly and then i will do it for FM.I am sorry for this mis
understanding
>
> Regards
>
> Marcel
>
>
>

Regards,
Ram.

[PATCH 2/2] Adding kerneldoc entry for radio type GPS

[janakiram.sistla]

From: Janakiram Sistla <janakiram.sistla@gmail.com>

Adding  kerneldoc entry for radio type GPS
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
 include/linux/rfkill.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index d787d5f..212f555 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -36,6 +36,7 @@
  * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
  * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
  * @RFKILL_TYPE_FM: switch is on a FM device.
+ * @RFKILL_TYPE_GPS: switch is on a GPS device.
  * @NUM_RFKILL_TYPES: number of defined rfkill types
  */
 enum rfkill_type {
-- 
1.5.4.3

Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS

[Marcel Holtmann]

Hi Janakiram,

> >>
> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> >> index d787d5f..212f555 100644
> >> --- a/include/linux/rfkill.h
> >> +++ b/include/linux/rfkill.h
> >> @@ -36,6 +36,7 @@
> >>   * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> >>   * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> >>   * @RFKILL_TYPE_FM: switch is on a FM device.
> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
> >>   * @NUM_RFKILL_TYPES: number of defined rfkill types
> >>   */
> >>  enum rfkill_type {
> >
> > so this is getting stupid right now. I am sick of a really simple patch
> > causes so much trouble. Even this one is wrong again. The GPS doc should
> > obviously before FM.
> Marcel I think you want me to submit GPS doc patch first.I will be
> doing it shortly and then i will do it for FM.I am sorry for this mis
> understanding

I don't care in which order you submit the patches, but the order of the
documentation should match the order in the enum. That is not a strict
requirement, but here it makes total sense to do so.

Also don't worry with the patches anymore. This took way too much ping
pong to get it right, that I just wrote them by myself and submitted
them for inclusion.

Regards

Marcel

Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS

[Janakiram Sistla]

On Wed, Nov 18, 2009 at 9:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> >>
>> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> >> index d787d5f..212f555 100644
>> >> --- a/include/linux/rfkill.h
>> >> +++ b/include/linux/rfkill.h
>> >> @@ -36,6 +36,7 @@
>> >>   * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> >>   * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> >>   * @RFKILL_TYPE_FM: switch is on a FM device.
>> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> >>   * @NUM_RFKILL_TYPES: number of defined rfkill types
>> >>   */
>> >>  enum rfkill_type {
>> >
>> > so this is getting stupid right now. I am sick of a really simple patch
>> > causes so much trouble. Even this one is wrong again. The GPS doc should
>> > obviously before FM.
>> Marcel I think you want me to submit GPS doc patch first.I will be
>> doing it shortly and then i will do it for FM.I am sorry for this mis
>> understanding
>
> I don't care in which order you submit the patches, but the order of the
> documentation should match the order in the enum. That is not a strict
> requirement, but here it makes total sense to do so.
>
> Also don't worry with the patches anymore. This took way too much ping
> pong to get it right, that I just wrote them by myself and submitted
> them for inclusion.

Hope you can loop me in for the same.So that i can use that patch.
>
> Regards
>
> Marcel
>
>
>

Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS

[Janakiram Sistla]

On Wed, Nov 18, 2009 at 9:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> >>
>> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> >> index d787d5f..212f555 100644
>> >> --- a/include/linux/rfkill.h
>> >> +++ b/include/linux/rfkill.h
>> >> @@ -36,6 +36,7 @@
>> >>   * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> >>   * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> >>   * @RFKILL_TYPE_FM: switch is on a FM device.
>> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> >>   * @NUM_RFKILL_TYPES: number of defined rfkill types
>> >>   */
>> >>  enum rfkill_type {
>> >
>> > so this is getting stupid right now. I am sick of a really simple patch
>> > causes so much trouble. Even this one is wrong again. The GPS doc should
>> > obviously before FM.
>> Marcel I think you want me to submit GPS doc patch first.I will be
>> doing it shortly and then i will do it for FM.I am sorry for this mis
>> understanding
>
> I don't care in which order you submit the patches, but the order of the
> documentation should match the order in the enum. That is not a strict
> requirement, but here it makes total sense to do so.
>
> Also don't worry with the patches anymore. This took way too much ping
> pong to get it right, that I just wrote them by myself and submitted
> them for inclusion.
>
> Regards
>
> Marcel
>
>
>

I hope in that case  i think it should be give signed off by both for
both the patches.

Regards,
Ram

Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS

[Janakiram Sistla]

On Wed, Nov 18, 2009 at 9:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> >>
>> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> >> index d787d5f..212f555 100644
>> >> --- a/include/linux/rfkill.h
>> >> +++ b/include/linux/rfkill.h
>> >> @@ -36,6 +36,7 @@
>> >>   * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> >>   * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> >>   * @RFKILL_TYPE_FM: switch is on a FM device.
>> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> >>   * @NUM_RFKILL_TYPES: number of defined rfkill types
>> >>   */
>> >>  enum rfkill_type {
>> >
>> > so this is getting stupid right now. I am sick of a really simple patch
>> > causes so much trouble. Even this one is wrong again. The GPS doc should
>> > obviously before FM.
>> Marcel I think you want me to submit GPS doc patch first.I will be
>> doing it shortly and then i will do it for FM.I am sorry for this mis
>> understanding
>
> I don't care in which order you submit the patches, but the order of the
> documentation should match the order in the enum. That is not a strict
> requirement, but here it makes total sense to do so.
>
> Also don't worry with the patches anymore. This took way too much ping
> pong to get it right, that I just wrote them by myself and submitted
> them for inclusion.

I hope in that case  i think it should be give signed off by both authors  for
both the patches.
> Regards
>
> Marcel
>
>
>

Regards,
Ram.