* mesh endian bugs
@ 2009-11-19 13:51 Johannes Berg
2009-11-19 15:50 ` Rui Paulo
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2009-11-19 13:51 UTC (permalink / raw)
To: Rui Paulo; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
CHECK /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: warning: incorrect type in argument 4 (different base types)
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: expected restricted __le16 [usertype] target_rcode
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: got int
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: warning: incorrect type in argument 4 (different base types)
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: expected restricted __le16 [usertype] target_rcode
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: got int
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mesh endian bugs
2009-11-19 13:51 mesh endian bugs Johannes Berg
@ 2009-11-19 15:50 ` Rui Paulo
2009-11-19 17:20 ` Dan Williams
2009-11-19 22:29 ` Johannes Berg
0 siblings, 2 replies; 5+ messages in thread
From: Rui Paulo @ 2009-11-19 15:50 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Hi,
On 19 Nov 2009, at 13:51, Johannes Berg wrote:
> CHECK /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: warning: incorrect type in argument 4 (different base types)
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: expected restricted __le16 [usertype] target_rcode
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: got int
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: warning: incorrect type in argument 4 (different base types)
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: expected restricted __le16 [usertype] target_rcode
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: got int
Thanks Johannes. How does one perform this check?
--
Rui Paulo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mesh endian bugs
2009-11-19 15:50 ` Rui Paulo
@ 2009-11-19 17:20 ` Dan Williams
2009-11-19 22:29 ` Johannes Berg
1 sibling, 0 replies; 5+ messages in thread
From: Dan Williams @ 2009-11-19 17:20 UTC (permalink / raw)
To: Rui Paulo; +Cc: Johannes Berg, linux-wireless
On Thu, 2009-11-19 at 15:50 +0000, Rui Paulo wrote:
> Hi,
>
> On 19 Nov 2009, at 13:51, Johannes Berg wrote:
>
> > CHECK /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: warning: incorrect type in argument 4 (different base types)
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: expected restricted __le16 [usertype] target_rcode
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: got int
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: warning: incorrect type in argument 4 (different base types)
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: expected restricted __le16 [usertype] target_rcode
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: got int
>
> Thanks Johannes. How does one perform this check?
With sparse:
http://lwn.net/Articles/205624/
Dan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mesh endian bugs
2009-11-19 15:50 ` Rui Paulo
2009-11-19 17:20 ` Dan Williams
@ 2009-11-19 22:29 ` Johannes Berg
2009-11-19 22:30 ` Johannes Berg
1 sibling, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2009-11-19 22:29 UTC (permalink / raw)
To: Rui Paulo; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On Thu, 2009-11-19 at 15:50 +0000, Rui Paulo wrote:
> Hi,
>
> On 19 Nov 2009, at 13:51, Johannes Berg wrote:
>
> > CHECK /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: warning: incorrect type in argument 4 (different base types)
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: expected restricted __le16 [usertype] target_rcode
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: got int
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: warning: incorrect type in argument 4 (different base types)
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: expected restricted __le16 [usertype] target_rcode
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: got int
>
> Thanks Johannes. How does one perform this check?
make M=net/mac80211 C=1
However, due to a stupid kmemcheck thing it's broken, runs into an error
in skbuff.h and you need to fix that first by removing the :16 on that
line.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mesh endian bugs
2009-11-19 22:29 ` Johannes Berg
@ 2009-11-19 22:30 ` Johannes Berg
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2009-11-19 22:30 UTC (permalink / raw)
To: Rui Paulo; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
On Thu, 2009-11-19 at 23:29 +0100, Johannes Berg wrote:
> make M=net/mac80211 C=1
or C=2 to check all files (C=1 checks files that are recompiled, C=2
checks all files)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-11-19 22:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-19 13:51 mesh endian bugs Johannes Berg
2009-11-19 15:50 ` Rui Paulo
2009-11-19 17:20 ` Dan Williams
2009-11-19 22:29 ` Johannes Berg
2009-11-19 22:30 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox