* [PATCH] mac80211: fix rcu locking
@ 2009-11-20 9:09 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-11-20 9:09 UTC (permalink / raw)
To: John Linville; +Cc: Felix Fietkau, linux-wireless
Add a missing rcu_read_unlock() before jumping out
of the ieee80211_change_station() function in the
error case.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
*points finger at*
commit fed1557d868e3a15b8a10700f79353e1f362e3a1
Author: Felix Fietkau <nbd@openwrt.org>
Date: Tue Nov 10 20:10:05 2009 +0100
mac80211: implement support for 4-address frames for AP and client mode
net/mac80211/cfg.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- wireless-testing.orig/net/mac80211/cfg.c 2009-11-20 10:04:21.000000000 +0100
+++ wireless-testing/net/mac80211/cfg.c 2009-11-20 10:04:37.000000000 +0100
@@ -818,8 +818,10 @@ static int ieee80211_change_station(stru
}
if (params->vlan->ieee80211_ptr->use_4addr) {
- if (vlansdata->u.vlan.sta)
+ if (vlansdata->u.vlan.sta) {
+ rcu_read_unlock();
return -EBUSY;
+ }
rcu_assign_pointer(vlansdata->u.vlan.sta, sta);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-11-20 9:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-20 9:09 [PATCH] mac80211: fix rcu locking Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox