Linux wireless drivers development
 help / color / mirror / Atom feed
* mac80211 not using get_tx_stats driver op?
@ 2009-11-28 19:33 Kalle Valo
  2009-11-28 19:59 ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2009-11-28 19:33 UTC (permalink / raw)
  To: linux-wireless; +Cc: johannes

Hello,

I noticed that mac80211 is not calling get_tx_stats op anywhere. Is
there a plan to use it somehow or can we just remove it?

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mac80211 not using get_tx_stats driver op?
  2009-11-28 19:33 mac80211 not using get_tx_stats driver op? Kalle Valo
@ 2009-11-28 19:59 ` Johannes Berg
  2009-11-28 20:04   ` Kalle Valo
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2009-11-28 19:59 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

On Sat, 2009-11-28 at 21:33 +0200, Kalle Valo wrote:
> Hello,
> 
> I noticed that mac80211 is not calling get_tx_stats op anywhere. Is
> there a plan to use it somehow or can we just remove it?

I thought there was a debugfs file for it? I think I once wanted to
remove it and then thought we'd keep the code ... there's probably
little value in it unless somebody knows a use case?

johannes


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mac80211 not using get_tx_stats driver op?
  2009-11-28 19:59 ` Johannes Berg
@ 2009-11-28 20:04   ` Kalle Valo
  0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2009-11-28 20:04 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-wireless

Johannes Berg <johannes@sipsolutions.net> writes:

> On Sat, 2009-11-28 at 21:33 +0200, Kalle Valo wrote:
>> Hello,
>> 
>> I noticed that mac80211 is not calling get_tx_stats op anywhere. Is
>> there a plan to use it somehow or can we just remove it?
>
> I thought there was a debugfs file for it?

If there is, I can't find it. I can see drivers implementing the op,
but I don't see mac80211 using it anywhere.

> I think I once wanted to remove it and then thought we'd keep the
> code ... there's probably little value in it unless somebody knows a
> use case?

If someone thinks of something, please tell me. Otherwise I will
submit a patch removing the code from both mac80211 and drivers. 

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-28 20:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-28 19:33 mac80211 not using get_tx_stats driver op? Kalle Valo
2009-11-28 19:59 ` Johannes Berg
2009-11-28 20:04   ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox