From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] mac80211: remove requeue from work
Date: Sat, 12 Dec 2009 16:29:43 +0100 [thread overview]
Message-ID: <1260631783.2442.335.camel@johannes.local> (raw)
There's no need to be requeueing the work struct
since we check for the scan after removing items
due to possible timeouts.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/work.c | 18 ------------------
1 file changed, 18 deletions(-)
--- wireless-testing.orig/net/mac80211/work.c 2009-12-12 16:29:08.000000000 +0100
+++ wireless-testing/net/mac80211/work.c 2009-12-12 16:29:11.000000000 +0100
@@ -435,12 +435,6 @@ ieee80211_direct_probe(struct ieee80211_
*/
ieee80211_remove_auth_bss(local, wk);
- /*
- * We might have a pending scan which had no chance to run yet
- * due to work needing to be done. Hence, queue the STAs work
- * again for that.
- */
- ieee80211_queue_work(&local->hw, &local->work_work);
return WORK_ACT_TIMEOUT;
}
@@ -478,12 +472,6 @@ ieee80211_authenticate(struct ieee80211_
*/
ieee80211_remove_auth_bss(local, wk);
- /*
- * We might have a pending scan which had no chance to run yet
- * due to work needing to be done. Hence, queue the STAs work
- * again for that.
- */
- ieee80211_queue_work(&local->hw, &local->work_work);
return WORK_ACT_TIMEOUT;
}
@@ -519,12 +507,6 @@ ieee80211_associate(struct ieee80211_wor
if (wk->assoc.bss)
cfg80211_unlink_bss(local->hw.wiphy, wk->assoc.bss);
- /*
- * We might have a pending scan which had no chance to run yet
- * due to work needing to be done. Hence, queue the STAs work
- * again for that.
- */
- ieee80211_queue_work(&local->hw, &local->work_work);
return WORK_ACT_TIMEOUT;
}
reply other threads:[~2009-12-13 1:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260631783.2442.335.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox