Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] mac80211: remove requeue from work
@ 2009-12-12 15:29 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-12-12 15:29 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

There's no need to be requeueing the work struct
since we check for the scan after removing items
due to possible timeouts.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/work.c |   18 ------------------
 1 file changed, 18 deletions(-)

--- wireless-testing.orig/net/mac80211/work.c	2009-12-12 16:29:08.000000000 +0100
+++ wireless-testing/net/mac80211/work.c	2009-12-12 16:29:11.000000000 +0100
@@ -435,12 +435,6 @@ ieee80211_direct_probe(struct ieee80211_
 		 */
 		ieee80211_remove_auth_bss(local, wk);
 
-		/*
-		 * We might have a pending scan which had no chance to run yet
-		 * due to work needing to be done. Hence, queue the STAs work
-		 * again for that.
-		 */
-		ieee80211_queue_work(&local->hw, &local->work_work);
 		return WORK_ACT_TIMEOUT;
 	}
 
@@ -478,12 +472,6 @@ ieee80211_authenticate(struct ieee80211_
 		 */
 		ieee80211_remove_auth_bss(local, wk);
 
-		/*
-		 * We might have a pending scan which had no chance to run yet
-		 * due to work needing to be done. Hence, queue the STAs work
-		 * again for that.
-		 */
-		ieee80211_queue_work(&local->hw, &local->work_work);
 		return WORK_ACT_TIMEOUT;
 	}
 
@@ -519,12 +507,6 @@ ieee80211_associate(struct ieee80211_wor
 		if (wk->assoc.bss)
 			cfg80211_unlink_bss(local->hw.wiphy, wk->assoc.bss);
 
-		/*
-		 * We might have a pending scan which had no chance to run yet
-		 * due to work needing to be done. Hence, queue the STAs work
-		 * again for that.
-		 */
-		ieee80211_queue_work(&local->hw, &local->work_work);
 		return WORK_ACT_TIMEOUT;
 	}
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-12-13  1:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-12 15:29 [PATCH] mac80211: remove requeue from work Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox