From: Dan Williams <dcbw@redhat.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Holger Schurig <holgerschurig@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: libertas driver carrier of signaling
Date: Wed, 16 Dec 2009 17:18:31 -0800 [thread overview]
Message-ID: <1261012711.17721.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20091216225524.GD3788@sortiz.org>
On Wed, 2009-12-16 at 23:55 +0100, Samuel Ortiz wrote:
> Hi guys,
>
> I was looking at the libertas driver and found that piece of code, at scan.c:
>
> /* We want to scan all channels */
> chan_count = lbs_scan_create_channel_list(priv, chan_list);
>
> netif_stop_queue(priv->dev);
> netif_carrier_off(priv->dev);
>
> So, why do we need to turn carrier off when scanning? I could barely see why
> we'd want to stop the netdev tx queue, but is turning carrier off really
> needed ?
Probably not. Carrier is largely useless with wireless drivers anyway,
though if they for some reason really, really want to use carrier,
carrier should only be on when the device is authed & associated to an
AP.
Dan
prev parent reply other threads:[~2009-12-17 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 22:55 libertas driver carrier of signaling Samuel Ortiz
2009-12-17 1:18 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261012711.17721.7.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=holgerschurig@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox