public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: Dan Williams <dcbw@redhat.com>, Holger Schurig <holgerschurig@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: libertas driver carrier of signaling
Date: Wed, 16 Dec 2009 23:55:24 +0100	[thread overview]
Message-ID: <20091216225524.GD3788@sortiz.org> (raw)

Hi guys,

I was looking at the libertas driver and found that piece of code, at scan.c:

/* We want to scan all channels */
	chan_count = lbs_scan_create_channel_list(priv, chan_list);

	netif_stop_queue(priv->dev);
	netif_carrier_off(priv->dev);

So, why do we need to turn carrier off when scanning? I could barely see why
we'd want to stop the netdev tx queue, but is turning carrier off really
needed ?

Thanks in advance for your answers.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

             reply	other threads:[~2009-12-16 22:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 22:55 Samuel Ortiz [this message]
2009-12-17  1:18 ` libertas driver carrier of signaling Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091216225524.GD3788@sortiz.org \
    --to=sameo@linux.intel.com \
    --cc=dcbw@redhat.com \
    --cc=holgerschurig@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox