* libertas driver carrier of signaling
@ 2009-12-16 22:55 Samuel Ortiz
2009-12-17 1:18 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Ortiz @ 2009-12-16 22:55 UTC (permalink / raw)
To: Dan Williams, Holger Schurig; +Cc: linux-wireless
Hi guys,
I was looking at the libertas driver and found that piece of code, at scan.c:
/* We want to scan all channels */
chan_count = lbs_scan_create_channel_list(priv, chan_list);
netif_stop_queue(priv->dev);
netif_carrier_off(priv->dev);
So, why do we need to turn carrier off when scanning? I could barely see why
we'd want to stop the netdev tx queue, but is turning carrier off really
needed ?
Thanks in advance for your answers.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: libertas driver carrier of signaling
2009-12-16 22:55 libertas driver carrier of signaling Samuel Ortiz
@ 2009-12-17 1:18 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2009-12-17 1:18 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Holger Schurig, linux-wireless
On Wed, 2009-12-16 at 23:55 +0100, Samuel Ortiz wrote:
> Hi guys,
>
> I was looking at the libertas driver and found that piece of code, at scan.c:
>
> /* We want to scan all channels */
> chan_count = lbs_scan_create_channel_list(priv, chan_list);
>
> netif_stop_queue(priv->dev);
> netif_carrier_off(priv->dev);
>
> So, why do we need to turn carrier off when scanning? I could barely see why
> we'd want to stop the netdev tx queue, but is turning carrier off really
> needed ?
Probably not. Carrier is largely useless with wireless drivers anyway,
though if they for some reason really, really want to use carrier,
carrier should only be on when the device is authed & associated to an
AP.
Dan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-17 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-16 22:55 libertas driver carrier of signaling Samuel Ortiz
2009-12-17 1:18 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox