public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2.6.33] mac80211: fix WMM AP settings application
@ 2009-12-17 15:16 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-12-17 15:16 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, Wey-Yi Guy

My
  commit 77fdaa12cea26c204cc12c312fe40bc0f3dcdfd8
  Author: Johannes Berg <johannes@sipsolutions.net>
  Date:   Tue Jul 7 03:45:17 2009 +0200

      mac80211: rework MLME for multiple authentications

inadvertedly broke WMM because it removed, along with
a bunch of other now useless initialisations, the line
initialising sdata->u.mgd.wmm_last_param_set to -1
which would make it adopt any WMM parameter set. If,
as is usually the case, the AP uses WMM parameter set
sequence number zero, we'd never update it until the
AP changes the sequence number.

Add the missing initialisation back to get the WMM
settings from the AP applied locally.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: stable@kernel.org [2.6.31+]
---
 net/mac80211/mlme.c |    8 ++++++++
 1 file changed, 8 insertions(+)

--- wireless-testing.orig/net/mac80211/mlme.c	2009-12-17 15:34:32.000000000 +0100
+++ wireless-testing/net/mac80211/mlme.c	2009-12-17 15:51:18.000000000 +0100
@@ -695,6 +695,14 @@ static void ieee80211_set_associated(str
 	sdata->u.mgd.flags &= ~(IEEE80211_STA_CONNECTION_POLL |
 				IEEE80211_STA_BEACON_POLL);
 
+	/*
+	 * Always handle WMM once after association regardless
+	 * of the first value the AP uses. Setting -1 here has
+	 * that effect because the AP values is an unsigned
+	 * 4-bit value.
+	 */
+	sdata->u.mgd.wmm_last_param_set = -1;
+
 	ieee80211_led_assoc(local, 1);
 
 	sdata->vif.bss_conf.assoc = 1;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-12-17 15:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-17 15:16 [PATCH 2.6.33] mac80211: fix WMM AP settings application Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox