From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH 2/5] mac80211: fix propagation of failed hardware reconfigurations
Date: Thu, 24 Dec 2009 13:38:23 +0100 [thread overview]
Message-ID: <1261658303.28729.4.camel@johannes.local> (raw)
In-Reply-To: <1261616609-518-3-git-send-email-lrodriguez@atheros.com>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Wed, 2009-12-23 at 20:03 -0500, Luis R. Rodriguez wrote:
> /* restart hardware */
> if (local->open_count) {
> + /*
> + * Upon resume hardware can sometimes be goofy due to
> + * various platform / driver / bus issues, so restarting
> + * the device may at times not work immediately. Propagate
> + * the error.
> + */
> res = drv_start(local);
> + if (res) {
> + WARN(local->suspended, "Harware became unavailable "
> + "upon resume likely due to a bug on mac80211, "
> + "your driver or a bus issue\n");
> + return res;
> + }
I object to the wording -- how would this be a mac80211 bug? :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-12-24 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 1:03 [PATCH 0/5] Few mac80211 and ath9k suspend fixes Luis R. Rodriguez
2009-12-24 1:03 ` [PATCH 1/5] mac80211: fix race with suspend and dynamic_ps_disable_work Luis R. Rodriguez
2009-12-24 12:41 ` Johannes Berg
2009-12-24 1:03 ` [PATCH 2/5] mac80211: fix propagation of failed hardware reconfigurations Luis R. Rodriguez
2009-12-24 12:38 ` Johannes Berg [this message]
2009-12-24 20:11 ` Luis R. Rodriguez
2009-12-24 1:03 ` [PATCH 3/5] ath9k: fix suspend by waking device prior to stop Luis R. Rodriguez
2009-12-24 1:03 ` [PATCH 4/5] ath9k: wake hardware for interface IBSS/AP/Mesh removal Luis R. Rodriguez
2009-12-24 1:03 ` [PATCH 5/5] ath9k: wake hardware during AMPDU TX actions Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261658303.28729.4.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox