From: reinette chatre <reinette.chatre@intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Zhu, Yi" <yi.zhu@intel.com>
Subject: Re: [PATCH] iwlwifi: remove IWLWIFI_VERSION
Date: Tue, 05 Jan 2010 16:08:15 -0800 [thread overview]
Message-ID: <1262736495.11849.305.camel@rc-desk> (raw)
In-Reply-To: <1262728499-31006-1-git-send-email-linville@tuxdriver.com>
Hi John,
On Tue, 2010-01-05 at 13:54 -0800, John W. Linville wrote:
> Also remove the MODULE_VERSION macros using IWLWIFI_VERSION. Those
> places using IWLWIFI_VERSION at runtime are modified to use
> init_utsname()->release instead.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> How about this as a compromise?
Thank you for looking at this.
I do think it is valuable for a user to see the parameters the module
was compiled with when running "modinfo". I thus would like the
MODULE_VERSION to stay. Including the kernel version number at runtime
seems fine. The version number display may be a bit strange when a user
did not compile with any of the options since the version number will
then end with "-".
Reinette
next prev parent reply other threads:[~2010-01-06 0:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 7:31 [PATCH] iwlwifi: remove generated/utsrelease.h dependency Zhu Yi
2009-12-24 7:43 ` Luis R. Rodriguez
2009-12-25 1:46 ` Zhu, Yi
2010-01-05 21:54 ` [PATCH] iwlwifi: remove IWLWIFI_VERSION John W. Linville
2010-01-06 0:08 ` reinette chatre [this message]
2009-12-24 8:20 ` [PATCH] iwlwifi: remove generated/utsrelease.h dependency Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262736495.11849.305.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox