public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mac80211: fix return from ieee80211_assoc_success
@ 2010-01-08 18:01 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2010-01-08 18:01 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

sparse pointed out that I made a mistake converting
the return value of ieee80211_assoc_success to bool,
this place should return false instead of one of the
enum values (which would be true).

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/mlme.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/mac80211/mlme.c	2010-01-08 18:24:44.000000000 +0100
+++ wireless-testing/net/mac80211/mlme.c	2010-01-08 18:24:53.000000000 +0100
@@ -1096,7 +1096,7 @@ static bool ieee80211_assoc_success(stru
 	if (err) {
 		printk(KERN_DEBUG "%s: failed to insert STA entry for"
 		       " the AP (error %d)\n", sdata->name, err);
-		return RX_MGMT_CFG80211_ASSOC_ERROR;
+		return false;
 	}
 
 	if (elems.wmm_param)



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-08 18:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-08 18:01 [PATCH] mac80211: fix return from ieee80211_assoc_success Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox