* [PATCH] mac80211: fix bss_conf.dtim_period
@ 2010-02-05 10:45 Johannes Berg
2010-02-05 15:52 ` Luis R. Rodriguez
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2010-02-05 10:45 UTC (permalink / raw)
To: linville; +Cc: linux-wireless
In AP mode, the only mode where the parameter
is supposed to be valid, we never assign it!
Fix that to allow drivers to avoid parsing
the TIM IE for the value.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/cfg.c | 2 ++
1 file changed, 2 insertions(+)
--- wireless-testing.orig/net/mac80211/cfg.c 2010-02-05 11:42:12.000000000 +0100
+++ wireless-testing/net/mac80211/cfg.c 2010-02-05 11:42:27.000000000 +0100
@@ -515,6 +515,8 @@ static int ieee80211_config_beacon(struc
if (old)
memcpy(new->tail, old->tail, new_tail_len);
+ sdata->vif.bss_conf.dtim_period = new->dtim_period;
+
rcu_assign_pointer(sdata->u.ap.beacon, new);
synchronize_rcu();
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: fix bss_conf.dtim_period
2010-02-05 10:45 [PATCH] mac80211: fix bss_conf.dtim_period Johannes Berg
@ 2010-02-05 15:52 ` Luis R. Rodriguez
2010-02-05 15:54 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2010-02-05 15:52 UTC (permalink / raw)
To: Johannes Berg; +Cc: linville, linux-wireless
On Fri, Feb 5, 2010 at 2:45 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> In AP mode, the only mode where the parameter
> is supposed to be valid, we never assign it!
> Fix that to allow drivers to avoid parsing
> the TIM IE for the value.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Stable fix too?
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: fix bss_conf.dtim_period
2010-02-05 15:52 ` Luis R. Rodriguez
@ 2010-02-05 15:54 ` Johannes Berg
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2010-02-05 15:54 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Fri, 2010-02-05 at 07:52 -0800, Luis R. Rodriguez wrote:
> On Fri, Feb 5, 2010 at 2:45 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > In AP mode, the only mode where the parameter
> > is supposed to be valid, we never assign it!
> > Fix that to allow drivers to avoid parsing
> > the TIM IE for the value.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> Stable fix too?
Seems no driver actually relies on it, so I guess not.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-05 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-05 10:45 [PATCH] mac80211: fix bss_conf.dtim_period Johannes Berg
2010-02-05 15:52 ` Luis R. Rodriguez
2010-02-05 15:54 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox