* [PATCH 2.6.34] mac80211: remove bogus TX agg state assignment
@ 2010-04-19 8:48 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2010-04-19 8:48 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless
When the addba timer expires but has no work to do,
it should not affect the state machine. If it does,
TX will not see the successfully established and we
can also crash trying to re-establish the session.
Cc: stable@kernel.org [2.6.32, 2.6.33]
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/agg-tx.c | 1 -
1 file changed, 1 deletion(-)
--- wireless-testing.orig/net/mac80211/agg-tx.c 2010-04-19 10:42:55.000000000 +0200
+++ wireless-testing/net/mac80211/agg-tx.c 2010-04-19 10:43:12.000000000 +0200
@@ -183,7 +183,6 @@ static void sta_addba_resp_timer_expired
HT_AGG_STATE_REQ_STOP_BA_MSK)) !=
HT_ADDBA_REQUESTED_MSK) {
spin_unlock_bh(&sta->lock);
- *state = HT_AGG_STATE_IDLE;
#ifdef CONFIG_MAC80211_HT_DEBUG
printk(KERN_DEBUG "timer expired on tid %d but we are not "
"(or no longer) expecting addBA response there",
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-19 8:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-19 8:48 [PATCH 2.6.34] mac80211: remove bogus TX agg state assignment Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox