From: Zhu Yi <yi.zhu@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Guy, Wey-Yi W" <wey-yi.w.guy@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"Kolekar, Abhijeet" <abhijeet.kolekar@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [patch 1/9] iwlwifi: remove stray mutex_unlock()
Date: Tue, 11 May 2010 09:12:53 +0800 [thread overview]
Message-ID: <1273540373.27831.40.camel@debian> (raw)
In-Reply-To: <20100508162101.GM27064@bicker>
On Sun, 2010-05-09 at 00:21 +0800, Dan Carpenter wrote:
> This mutex_unlock() has been here from the initial commit, but as nearly
> as I can tell, there isn't a reason for it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 9dad867..3faa78c 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -2482,7 +2482,6 @@ int iwl3945_hw_set_hw_params(struct iwl_priv *priv)
> &priv->_3945.shared_phys, GFP_KERNEL);
> if (!priv->_3945.shared_virt) {
> IWL_ERR(priv, "failed to allocate pci memory\n");
> - mutex_unlock(&priv->mutex);
> return -ENOMEM;
> }
Yeah, a mistake, definitely.
Acked-by: Zhu Yi <yi.zhu@intel.com>
Thanks,
-yi
prev parent reply other threads:[~2010-05-11 1:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 16:21 [patch 1/9] iwlwifi: remove stray mutex_unlock() Dan Carpenter
2010-05-11 1:12 ` Zhu Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273540373.27831.40.camel@debian \
--to=yi.zhu@intel.com \
--cc=abhijeet.kolekar@intel.com \
--cc=error27@gmail.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox