From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless: correct sparse warning in wext-compat.c
Date: Tue, 20 Jul 2010 18:39:50 +0200 [thread overview]
Message-ID: <1279643990.3706.44.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1279643215-13498-1-git-send-email-linville@tuxdriver.com>
On Tue, 2010-07-20 at 12:26 -0400, John W. Linville wrote:
> CHECK net/wireless/wext-compat.c
> net/wireless/wext-compat.c:1434:5: warning: symbol 'cfg80211_wext_siwpmksa' was not declared. Should it be static?
>
> Add declaration in cfg80211.h. Also add an EXPORT_SYMBOL_GPL, since all
> the peer functions have it.
Or it could just be static, since it seems unlikely somebody wants to
use it for orinoco or a similar half-converted driver? Anyway I don't
mind this patch either.
johannes
prev parent reply other threads:[~2010-07-20 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 16:26 [PATCH] wireless: correct sparse warning in wext-compat.c John W. Linville
2010-07-20 16:39 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279643990.3706.44.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox