[PATCH] wireless: correct sparse warning in wext-compat.c

[PATCH] wireless: correct sparse warning in wext-compat.c

[John W. Linville]

  CHECK   net/wireless/wext-compat.c
net/wireless/wext-compat.c:1434:5: warning: symbol 'cfg80211_wext_siwpmksa' was not declared. Should it be static?

Add declaration in cfg80211.h.  Also add an EXPORT_SYMBOL_GPL, since all
the peer functions have it.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 include/net/cfg80211.h     |    4 ++++
 net/wireless/wext-compat.c |    1 +
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 9b8b3f4..f68ae54 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -1963,6 +1963,10 @@ int cfg80211_wext_giwap(struct net_device *dev,
 			struct iw_request_info *info,
 			struct sockaddr *ap_addr, char *extra);
 
+int cfg80211_wext_siwpmksa(struct net_device *dev,
+			   struct iw_request_info *info,
+			   struct iw_point *data, char *extra);
+
 /*
  * callbacks for asynchronous cfg80211 methods, notification
  * functions and BSS handling helpers
diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c
index 1ff1e9f..bb5e0a5 100644
--- a/net/wireless/wext-compat.c
+++ b/net/wireless/wext-compat.c
@@ -1471,6 +1471,7 @@ int cfg80211_wext_siwpmksa(struct net_device *dev,
 		return -EOPNOTSUPP;
 	}
 }
+EXPORT_SYMBOL_GPL(cfg80211_wext_siwpmksa);
 
 static const iw_handler cfg80211_handlers[] = {
 	[IW_IOCTL_IDX(SIOCGIWNAME)]	= (iw_handler) cfg80211_wext_giwname,
-- 
1.7.1.1

Re: [PATCH] wireless: correct sparse warning in wext-compat.c

[Johannes Berg]

On Tue, 2010-07-20 at 12:26 -0400, John W. Linville wrote:
> CHECK   net/wireless/wext-compat.c
> net/wireless/wext-compat.c:1434:5: warning: symbol 'cfg80211_wext_siwpmksa' was not declared. Should it be static?
> 
> Add declaration in cfg80211.h.  Also add an EXPORT_SYMBOL_GPL, since all
> the peer functions have it.

Or it could just be static, since it seems unlikely somebody wants to
use it for orinoco or a similar half-converted driver? Anyway I don't
mind this patch either.

johannes