From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Wey-Yi Guy <wey-yi.w.guy@intel.com>
Subject: [PATCH 04/16] iwlwifi: make aggregation time limit configurable
Date: Wed, 18 Aug 2010 09:22:39 -0700 [thread overview]
Message-ID: <1282148571-9258-5-git-send-email-wey-yi.w.guy@intel.com> (raw)
In-Reply-To: <1282148571-9258-1-git-send-email-wey-yi.w.guy@intel.com>
By default, aggregation time limit is 4000 uSec, add the parameter to
.cfg
to allow this parameter can be configure per device base if needed.
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
---
drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 10 ++++++++++
drivers/net/wireless/iwlwifi/iwl-commands.h | 6 ++++--
drivers/net/wireless/iwlwifi/iwl-core.h | 2 ++
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
index 23e5c42..7c4deee 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
@@ -2694,8 +2694,18 @@ static void rs_fill_link_cmd(struct iwl_priv *priv,
lq_cmd->agg_params.agg_frame_cnt_limit = LINK_QUAL_AGG_FRAME_LIMIT_DEF;
lq_cmd->agg_params.agg_dis_start_th = LINK_QUAL_AGG_DISABLE_START_DEF;
+
lq_cmd->agg_params.agg_time_limit =
cpu_to_le16(LINK_QUAL_AGG_TIME_LIMIT_DEF);
+ /*
+ * overwrite if needed, pass aggregation time limit
+ * to uCode in uSec
+ */
+ if (priv && priv->cfg->agg_time_limit &&
+ priv->cfg->agg_time_limit >= LINK_QUAL_AGG_TIME_LIMIT_MIN &&
+ priv->cfg->agg_time_limit <= LINK_QUAL_AGG_TIME_LIMIT_MAX)
+ lq_cmd->agg_params.agg_time_limit =
+ cpu_to_le16(priv->cfg->agg_time_limit);
}
static void *rs_alloc(struct ieee80211_hw *hw, struct dentry *debugfsdir)
diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h b/drivers/net/wireless/iwlwifi/iwl-commands.h
index c6a0470..14a7a8c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-commands.h
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h
@@ -2110,8 +2110,10 @@ struct iwl_link_qual_general_params {
*/
struct iwl_link_qual_agg_params {
- /* Maximum number of uSec in aggregation.
- * Driver should set this to 4000 (4 milliseconds). */
+ /*
+ *Maximum number of uSec in aggregation.
+ * default set to 4000 (4 milliseconds) if not configured in .cfg
+ */
__le16 agg_time_limit;
/*
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.h b/drivers/net/wireless/iwlwifi/iwl-core.h
index 51ebd03..17fae00 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.h
+++ b/drivers/net/wireless/iwlwifi/iwl-core.h
@@ -280,6 +280,7 @@ struct iwl_mod_params {
* @scan_antennas: available antenna for scan operation
* @need_dc_calib: need to perform init dc calibration
* @bt_statistics: use BT version of statistics notification
+ * @agg_time_limit: maximum number of uSec in aggregation
*
* We enable the driver to be backward compatible wrt API version. The
* driver specifies which APIs it supports (with @ucode_api_max being the
@@ -350,6 +351,7 @@ struct iwl_cfg {
u8 scan_tx_antennas[IEEE80211_NUM_BANDS];
const bool need_dc_calib;
const bool bt_statistics;
+ u16 agg_time_limit;
};
/***************************
--
1.7.0.4
next prev parent reply other threads:[~2010-08-18 16:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 16:22 [PATCH 00/16] iwlwifi update for 2.6.37 Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 01/16] iwlwifi: remove unused define Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 02/16] iwlwifi: additional comments in iwl_cfg Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 03/16] iwlwifi: max/min aggregation time limit Wey-Yi Guy
2010-08-18 16:22 ` Wey-Yi Guy [this message]
2010-08-18 16:22 ` [PATCH 05/16] iwlwifi: do not call ieee80211_frequency_to_channel Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 06/16] iwlwifi: avoid race condition in channel change Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 07/16] iwlwifi: cleanup iwl_set_rxon_channel() Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 08/16] iwlwifi: refactor iwl_setup_rxon_timing Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 09/16] iwlagn: adjust starting action for rate scale Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 10/16] iwlagn: continue perform rate scale when error detected Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 11/16] iwlwifi: additional parameter in REPLY_RX_PHY_CMD Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 12/16] iwlwifi: more generic name for rssi calc in iwlagn Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 13/16] iwlwifi: configurable ampdu factor and density Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 14/16] iwlwifi: remove unused iwl_send_card_state function Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 15/16] iwlwifi: enable experimental ucode support Wey-Yi Guy
2010-08-18 16:22 ` [PATCH 16/16] iwlwifi: move debug options into submenu Wey-Yi Guy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282148571-9258-5-git-send-email-wey-yi.w.guy@intel.com \
--to=wey-yi.w.guy@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox