From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Berg, Johannes" <johannes.berg@intel.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH] iwlwifi: fix sparse warning about wrong enum for band parameter
Date: Wed, 15 Sep 2010 12:30:42 -0700 [thread overview]
Message-ID: <1284579042.25028.17.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1284578182-12684-1-git-send-email-linville@tuxdriver.com>
Hi John,
On Wed, 2010-09-15 at 12:16 -0700, John W. Linville wrote:
> drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum nl80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum ieee80211_band
> drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: int enum ieee80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: int enum nl80211_band
> drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: int enum ieee80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: int enum nl80211_band
> drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: int enum ieee80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: int enum nl80211_band
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-scan.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
> index 599573f..c54c200 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-scan.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
> @@ -350,7 +350,7 @@ EXPORT_SYMBOL(iwl_init_scan_params);
> static int __must_check iwl_scan_initiate(struct iwl_priv *priv,
> struct ieee80211_vif *vif,
> bool internal,
> - enum nl80211_band band)
> + enum ieee80211_band band)
> {
> int ret;
>
Thank you for fixing this, I also notice this and have the same patch
internally. I will drop my since you already fix it :-)
Wey
prev parent reply other threads:[~2010-09-15 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 19:16 [PATCH] iwlwifi: fix sparse warning about wrong enum for band parameter John W. Linville
2010-09-15 19:30 ` Guy, Wey-Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284579042.25028.17.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox