* [PATCH] iwlwifi: fix sparse warning about wrong enum for band parameter
@ 2010-09-15 19:16 John W. Linville
2010-09-15 19:30 ` Guy, Wey-Yi
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2010-09-15 19:16 UTC (permalink / raw)
To: linux-wireless
Cc: Wey-Yi W Guy, Johannes Berg, Stanislaw Gruszka, John W. Linville
drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: warning: mixing different enum types
drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum nl80211_band versus
drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum ieee80211_band
drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: warning: mixing different enum types
drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: int enum ieee80211_band versus
drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: int enum nl80211_band
drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: warning: mixing different enum types
drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: int enum ieee80211_band versus
drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: int enum nl80211_band
drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: warning: mixing different enum types
drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: int enum ieee80211_band versus
drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: int enum nl80211_band
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/iwlwifi/iwl-scan.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index 599573f..c54c200 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -350,7 +350,7 @@ EXPORT_SYMBOL(iwl_init_scan_params);
static int __must_check iwl_scan_initiate(struct iwl_priv *priv,
struct ieee80211_vif *vif,
bool internal,
- enum nl80211_band band)
+ enum ieee80211_band band)
{
int ret;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iwlwifi: fix sparse warning about wrong enum for band parameter
2010-09-15 19:16 [PATCH] iwlwifi: fix sparse warning about wrong enum for band parameter John W. Linville
@ 2010-09-15 19:30 ` Guy, Wey-Yi
0 siblings, 0 replies; 2+ messages in thread
From: Guy, Wey-Yi @ 2010-09-15 19:30 UTC (permalink / raw)
To: John W. Linville
Cc: linux-wireless@vger.kernel.org, Berg, Johannes, Stanislaw Gruszka
Hi John,
On Wed, 2010-09-15 at 12:16 -0700, John W. Linville wrote:
> drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum nl80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum ieee80211_band
> drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: int enum ieee80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: int enum nl80211_band
> drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: int enum ieee80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:474:53: int enum nl80211_band
> drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: warning: mixing different enum types
> drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: int enum ieee80211_band versus
> drivers/net/wireless/iwlwifi/iwl-scan.c:588:72: int enum nl80211_band
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-scan.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
> index 599573f..c54c200 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-scan.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
> @@ -350,7 +350,7 @@ EXPORT_SYMBOL(iwl_init_scan_params);
> static int __must_check iwl_scan_initiate(struct iwl_priv *priv,
> struct ieee80211_vif *vif,
> bool internal,
> - enum nl80211_band band)
> + enum ieee80211_band band)
> {
> int ret;
>
Thank you for fixing this, I also notice this and have the same patch
internally. I will drop my since you already fix it :-)
Wey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-15 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-15 19:16 [PATCH] iwlwifi: fix sparse warning about wrong enum for band parameter John W. Linville
2010-09-15 19:30 ` Guy, Wey-Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox