Re: [PATCH 1/3] ath5k: move nohwcrypt to ath_common structure

[Joe Perches <joe@perches.com>]

On Wed, 2011-01-05 at 14:22 -0500, John W. Linville wrote:

> diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
[]
> +	bool nohwcrypt;

> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> -int modparam_nohwcrypt;
> +static int modparam_nohwcrypt;
>  module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);

bool/int matching?

Perhaps the modparam_nohwcrypts should be
bool and S_IRUGO

> diff --git a/drivers/net/wireless/ath/ath9k/init.c 
[]
> -int modparam_nohwcrypt;
> +static int modparam_nohwcrypt;
>  module_param_named(nohwcrypt, modparam_nohwcrypt, int, 0444);

> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c 
[]
> -int htc_modparam_nohwcrypt;
> -module_param_named(nohwcrypt, htc_modparam_nohwcrypt, int, 0444);
> +static int modparam_nohwcrypt;
> +module_param_named(nohwcrypt, modparam_nohwcrypt, int, 0444);