From: Joe Perches <joe@perches.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH 1/3] ath5k: move nohwcrypt to ath_common structure
Date: Wed, 05 Jan 2011 11:53:59 -0800 [thread overview]
Message-ID: <1294257239.12561.12.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTi=v3oHGiQjASQqChmmsXHuv=UF17_A9XdeFeFNR@mail.gmail.com>
On Wed, 2011-01-05 at 14:49 -0500, Bob Copeland wrote:
> On Wed, Jan 5, 2011 at 2:40 PM, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2011-01-05 at 14:22 -0500, John W. Linville wrote:
> >> diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
> > []
> >> + bool nohwcrypt;
> >> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> >> -int modparam_nohwcrypt;
> >> +static int modparam_nohwcrypt;
> >> module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
> > bool/int matching?
> It used to be the case that you had to use ints here. Google tells me
> that changed about 2 years ago, so bool should be ok.
bool is OK.
modparam_nohwcrypt is declared int and should be declared bool.
Also should be declared and used as bool in ath9k and ath9k_htc too.
next prev parent reply other threads:[~2011-01-05 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 19:22 [PATCH 1/3] ath5k: move nohwcrypt to ath_common structure John W. Linville
2011-01-05 19:22 ` [PATCH 2/3] ath9k: use nohwcrypt in " John W. Linville
2011-01-05 19:22 ` [PATCH 3/3] ath9k_htc: " John W. Linville
2011-01-05 19:40 ` [PATCH 1/3] ath5k: move nohwcrypt to " Joe Perches
2011-01-05 19:49 ` Bob Copeland
2011-01-05 19:53 ` Joe Perches [this message]
2011-01-05 20:09 ` [ath5k-devel] " Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294257239.12561.12.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox