[RFC/WIP 23/33] ath9k_htc: Enable AP mode

[RFC/WIP 23/33] ath9k_htc: Enable AP mode

[Sujith]

From: Sujith Manoharan <Sujith.Manoharan@atheros.com>

Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
---
 drivers/net/wireless/ath/ath9k/htc_drv_init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
index dc96c06..b4ae719 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
@@ -753,7 +753,8 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
 
 	hw->wiphy->interface_modes =
 		BIT(NL80211_IFTYPE_STATION) |
-		BIT(NL80211_IFTYPE_ADHOC);
+		BIT(NL80211_IFTYPE_ADHOC) |
+		BIT(NL80211_IFTYPE_AP);
 
 	hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
 
-- 
1.7.3.5

Re: [RFC/WIP 23/33] ath9k_htc: Enable AP mode

[Johannes Berg]

On Fri, 2011-01-21 at 08:32 +0530, Sujith wrote:
> From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> 
> Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> ---
>  drivers/net/wireless/ath/ath9k/htc_drv_init.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> index dc96c06..b4ae719 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> @@ -753,7 +753,8 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
>  
>  	hw->wiphy->interface_modes =
>  		BIT(NL80211_IFTYPE_STATION) |
> -		BIT(NL80211_IFTYPE_ADHOC);
> +		BIT(NL80211_IFTYPE_ADHOC) |
> +		BIT(NL80211_IFTYPE_AP);

It'd be kinda nice if that could be made dependent on firmware
capability bits or version since otherwise everybody will think they
have it ... and it will not work?

johannes

Re: [RFC/WIP 23/33] ath9k_htc: Enable AP mode

[Sujith]

Johannes Berg wrote:
> On Fri, 2011-01-21 at 08:32 +0530, Sujith wrote:
> > From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> > 
> > Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> > ---
> >  drivers/net/wireless/ath/ath9k/htc_drv_init.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> > index dc96c06..b4ae719 100644
> > --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> > @@ -753,7 +753,8 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
> >  
> >  	hw->wiphy->interface_modes =
> >  		BIT(NL80211_IFTYPE_STATION) |
> > -		BIT(NL80211_IFTYPE_ADHOC);
> > +		BIT(NL80211_IFTYPE_ADHOC) |
> > +		BIT(NL80211_IFTYPE_AP);
> 
> It'd be kinda nice if that could be made dependent on firmware
> capability bits or version since otherwise everybody will think they
> have it ... and it will not work?

Well, the current firmware has no version mechanism and this series requires
the new FW for non-AP modes too. I am aware that breaking compatibilty with existing FW
is frowned upon, but unfortunately this is required since the command layout has
been cleaned up. I'll add a check to bail out at driver load time when the old FW is used.

Sujith