* [PATCH] WLAN: fix the path to the wl12xx firmwares
@ 2011-02-23 13:25 Sebastien Jan
2011-02-23 14:33 ` Luciano Coelho
2011-03-03 15:39 ` Luciano Coelho
0 siblings, 2 replies; 6+ messages in thread
From: Sebastien Jan @ 2011-02-23 13:25 UTC (permalink / raw)
To: Luciano Coelho, linux-wireless; +Cc: Sebastien Jan
Validated FW loading on a Ubuntu Natty alpha image, on a pandaboard
(embedding a WL1271).
Signed-off-by: Sebastien Jan <s-jan@ti.com>
---
Applies on a 2.6.38-rc5 kernel
drivers/net/wireless/wl12xx/wl12xx.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
index 9050dd9..8ceb6a0 100644
--- a/drivers/net/wireless/wl12xx/wl12xx.h
+++ b/drivers/net/wireless/wl12xx/wl12xx.h
@@ -112,8 +112,8 @@ extern u32 wl12xx_debug_level;
CFG_RX_CTL_EN | CFG_RX_BCN_EN | \
CFG_RX_AUTH_EN | CFG_RX_ASSOC_EN)
-#define WL1271_FW_NAME "wl1271-fw.bin"
-#define WL1271_NVS_NAME "wl1271-nvs.bin"
+#define WL1271_FW_NAME "ti-connectivity/wl1271-fw.bin"
+#define WL1271_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
#define WL1271_TX_SECURITY_LO16(s) ((u16)((s) & 0xffff))
#define WL1271_TX_SECURITY_HI32(s) ((u32)(((s) >> 16) & 0xffffffff))
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] WLAN: fix the path to the wl12xx firmwares
2011-02-23 13:25 [PATCH] WLAN: fix the path to the wl12xx firmwares Sebastien Jan
@ 2011-02-23 14:33 ` Luciano Coelho
2011-02-23 14:41 ` John W. Linville
2011-03-03 15:39 ` Luciano Coelho
1 sibling, 1 reply; 6+ messages in thread
From: Luciano Coelho @ 2011-02-23 14:33 UTC (permalink / raw)
To: Sebastien Jan; +Cc: linux-wireless
Hi Sebastien,
On Wed, 2011-02-23 at 14:25 +0100, Sebastien Jan wrote:
> Validated FW loading on a Ubuntu Natty alpha image, on a pandaboard
> (embedding a WL1271).
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
> ---
Thanks for working on getting the wl12xx driver to work on the
pandaboard!
> diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
> index 9050dd9..8ceb6a0 100644
> --- a/drivers/net/wireless/wl12xx/wl12xx.h
> +++ b/drivers/net/wireless/wl12xx/wl12xx.h
> @@ -112,8 +112,8 @@ extern u32 wl12xx_debug_level;
> CFG_RX_CTL_EN | CFG_RX_BCN_EN | \
> CFG_RX_AUTH_EN | CFG_RX_ASSOC_EN)
>
> -#define WL1271_FW_NAME "wl1271-fw.bin"
> -#define WL1271_NVS_NAME "wl1271-nvs.bin"
> +#define WL1271_FW_NAME "ti-connectivity/wl1271-fw.bin"
> +#define WL1271_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
You're right. Our firmware is (unfortunately) inside the
ti-connectivity in linux-firmware.git. So it would make sense to
include the ti-connectivity/ directory when requesting for the firmware,
but it's just damn ugly. :( The driver should not care at all where the
firmware is to be fetched from, that should be up to the userspace.
Dunno what is the best thing to do about this. Add the directory to the
driver? Move the wl1271*.bin files to the root of linux-firmware? Does
anybody have opinions about it?
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WLAN: fix the path to the wl12xx firmwares
2011-02-23 14:33 ` Luciano Coelho
@ 2011-02-23 14:41 ` John W. Linville
2011-02-23 14:54 ` Luciano Coelho
0 siblings, 1 reply; 6+ messages in thread
From: John W. Linville @ 2011-02-23 14:41 UTC (permalink / raw)
To: Luciano Coelho; +Cc: Sebastien Jan, linux-wireless
On Wed, Feb 23, 2011 at 04:33:19PM +0200, Luciano Coelho wrote:
> Hi Sebastien,
>
> On Wed, 2011-02-23 at 14:25 +0100, Sebastien Jan wrote:
> > Validated FW loading on a Ubuntu Natty alpha image, on a pandaboard
> > (embedding a WL1271).
> >
> > Signed-off-by: Sebastien Jan <s-jan@ti.com>
> > ---
>
> Thanks for working on getting the wl12xx driver to work on the
> pandaboard!
>
> > diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
> > index 9050dd9..8ceb6a0 100644
> > --- a/drivers/net/wireless/wl12xx/wl12xx.h
> > +++ b/drivers/net/wireless/wl12xx/wl12xx.h
> > @@ -112,8 +112,8 @@ extern u32 wl12xx_debug_level;
> > CFG_RX_CTL_EN | CFG_RX_BCN_EN | \
> > CFG_RX_AUTH_EN | CFG_RX_ASSOC_EN)
> >
> > -#define WL1271_FW_NAME "wl1271-fw.bin"
> > -#define WL1271_NVS_NAME "wl1271-nvs.bin"
> > +#define WL1271_FW_NAME "ti-connectivity/wl1271-fw.bin"
> > +#define WL1271_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
>
> You're right. Our firmware is (unfortunately) inside the
> ti-connectivity in linux-firmware.git. So it would make sense to
> include the ti-connectivity/ directory when requesting for the firmware,
> but it's just damn ugly. :( The driver should not care at all where the
> firmware is to be fetched from, that should be up to the userspace.
>
> Dunno what is the best thing to do about this. Add the directory to the
> driver? Move the wl1271*.bin files to the root of linux-firmware? Does
> anybody have opinions about it?
I think there are a number of other drivers with embedded pathnames.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WLAN: fix the path to the wl12xx firmwares
2011-02-23 14:41 ` John W. Linville
@ 2011-02-23 14:54 ` Luciano Coelho
2011-02-23 15:15 ` Larry Finger
0 siblings, 1 reply; 6+ messages in thread
From: Luciano Coelho @ 2011-02-23 14:54 UTC (permalink / raw)
To: John W. Linville; +Cc: Sebastien Jan, linux-wireless
On Wed, 2011-02-23 at 09:41 -0500, John W. Linville wrote:
> > > diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
> > > index 9050dd9..8ceb6a0 100644
> > > --- a/drivers/net/wireless/wl12xx/wl12xx.h
> > > +++ b/drivers/net/wireless/wl12xx/wl12xx.h
> > > @@ -112,8 +112,8 @@ extern u32 wl12xx_debug_level;
> > > CFG_RX_CTL_EN | CFG_RX_BCN_EN | \
> > > CFG_RX_AUTH_EN | CFG_RX_ASSOC_EN)
> > >
> > > -#define WL1271_FW_NAME "wl1271-fw.bin"
> > > -#define WL1271_NVS_NAME "wl1271-nvs.bin"
> > > +#define WL1271_FW_NAME "ti-connectivity/wl1271-fw.bin"
> > > +#define WL1271_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
> >
> > You're right. Our firmware is (unfortunately) inside the
> > ti-connectivity in linux-firmware.git. So it would make sense to
> > include the ti-connectivity/ directory when requesting for the firmware,
> > but it's just damn ugly. :( The driver should not care at all where the
> > firmware is to be fetched from, that should be up to the userspace.
> >
> > Dunno what is the best thing to do about this. Add the directory to the
> > driver? Move the wl1271*.bin files to the root of linux-firmware? Does
> > anybody have opinions about it?
>
> I think there are a number of other drivers with embedded pathnames.
Indeed. And, as discussed with Johannes on IRC, the / will be just one
more character in the FW name, regardless of whether it means a
subdirectory or not. It's just part of the FW name string.
When I apply the patch, I just need to brace for the loads of people
complaining that the FW cannot be found anymore and explain the issue a
hundred times. ;)
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WLAN: fix the path to the wl12xx firmwares
2011-02-23 14:54 ` Luciano Coelho
@ 2011-02-23 15:15 ` Larry Finger
0 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2011-02-23 15:15 UTC (permalink / raw)
To: Luciano Coelho; +Cc: John W. Linville, Sebastien Jan, linux-wireless
On 02/23/2011 08:54 AM, Luciano Coelho wrote:
> On Wed, 2011-02-23 at 09:41 -0500, John W. Linville wrote:
>>
>> I think there are a number of other drivers with embedded pathnames.
>
> Indeed. And, as discussed with Johannes on IRC, the / will be just one
> more character in the FW name, regardless of whether it means a
> subdirectory or not. It's just part of the FW name string.
>
> When I apply the patch, I just need to brace for the loads of people
> complaining that the FW cannot be found anymore and explain the issue a
> hundred times. ;)
You could keep the old path as a fallback for a couple of cycles and log a
message warning users to move their firmware.
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WLAN: fix the path to the wl12xx firmwares
2011-02-23 13:25 [PATCH] WLAN: fix the path to the wl12xx firmwares Sebastien Jan
2011-02-23 14:33 ` Luciano Coelho
@ 2011-03-03 15:39 ` Luciano Coelho
1 sibling, 0 replies; 6+ messages in thread
From: Luciano Coelho @ 2011-03-03 15:39 UTC (permalink / raw)
To: Sebastien Jan; +Cc: linux-wireless
On Wed, 2011-02-23 at 14:25 +0100, Sebastien Jan wrote:
> Validated FW loading on a Ubuntu Natty alpha image, on a pandaboard
> (embedding a WL1271).
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
> ---
Applied with small modifications: merged with the latest code and
changed the description to something more generic (this is not only
about pandaboard).
Thanks Jan!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-03 15:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 13:25 [PATCH] WLAN: fix the path to the wl12xx firmwares Sebastien Jan
2011-02-23 14:33 ` Luciano Coelho
2011-02-23 14:41 ` John W. Linville
2011-02-23 14:54 ` Luciano Coelho
2011-02-23 15:15 ` Larry Finger
2011-03-03 15:39 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox