[PATCH] lib-average: Make config option selectable

[PATCH] lib-average: Make config option selectable

[Michael Buesch]

Make CONFIG_AVERAGE selectable for out-of-tree users
such as compat-wireless.

Signed-off-by: Michael Buesch <mb@bu3sch.de>

---

Index: linux-2.6.38-rc6/lib/Kconfig
===================================================================
--- linux-2.6.38-rc6.orig/lib/Kconfig	2011-03-01 19:24:16.246703947 +0100
+++ linux-2.6.38-rc6/lib/Kconfig	2011-03-01 19:26:58.696312483 +0100
@@ -223,6 +223,13 @@ config LRU_CACHE
 	tristate
 
 config AVERAGE
-	bool
+	bool "Averaging functions"
+	help
+	  This option is provided for the case where no in-kernel-tree
+	  modules require averaging functions, but a module built outside
+	  the kernel tree does. Such modules that use library averaging
+	  functions require Y here.
+
+	  If unsure, say N.
 
 endmenu

-- 
Greetings, Michael.

Re: [PATCH] lib-average: Make config option selectable

[Johannes Berg]

On Tue, 2011-03-01 at 20:03 +0100, Michael Buesch wrote:
> Make CONFIG_AVERAGE selectable for out-of-tree users
> such as compat-wireless.

Is that really necessary? We haven't typically done this, and often just
shipped the code in compat instead?

johannes

Re: [PATCH] lib-average: Make config option selectable

[Michael Buesch]

On Tue, 2011-03-01 at 20:07 +0100, Johannes Berg wrote:
> On Tue, 2011-03-01 at 20:03 +0100, Michael Buesch wrote:
> > Make CONFIG_AVERAGE selectable for out-of-tree users
> > such as compat-wireless.
> 
> Is that really necessary? We haven't typically done this, and often just
> shipped the code in compat instead?

Well, there are a lot more options in lib that do this (The help text is
copied from the others).

compat-wireless does include a backport of the
function, but only for <=2.6.37. So from .38 on
compat-wireless expects the option to be enabled.
Which is unfortunate, because it's impossible to
enable without enabling something else that SELECTs
it. I hit this situation in OpenWRT.

-- 
Greetings, Michael.