From: Joe Perches <joe@perches.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Marc Yang <yangyang@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH v2] mwifiex: remove PRINTM/HEXDUMP and associated
Date: Thu, 03 Mar 2011 00:07:26 -0800 [thread overview]
Message-ID: <1299139646.4338.69.camel@Joe-Laptop> (raw)
In-Reply-To: <1299105113-3052-1-git-send-email-bzhao@marvell.com>
On Wed, 2011-03-02 at 14:31 -0800, Bing Zhao wrote:
> use pr_debug family APIs instead.
> MERROR/MFATAL/MMSG: pr_err, pr_warning, pr_notice
Trivia:
It looks to me as if all the MFATAL should
map to KERN_ERR.
Please use pr_fmt
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
to prefix "mwifiex: " rather than put it each
format string.
Please use pr_warn not pr_warning.
I really don't think you need to add another prefix
string like "err" and "info" and "cmd" to the various
levels. The output content is enough to figure it out.
Perhaps use use dev/netdev/wiphy_<level> where it makes
sense?
You've sometimes added __func__ and sometimes used or
kept some shortened function name equivalent. It'd
probably be better to consistently use __func__ where
appropriate.
next prev parent reply other threads:[~2011-03-03 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 22:31 [PATCH v2] mwifiex: remove PRINTM/HEXDUMP and associated Bing Zhao
2011-03-03 8:07 ` Joe Perches [this message]
2011-03-03 19:24 ` Bing Zhao
2011-03-03 20:10 ` Joe Perches
2011-03-03 20:58 ` Bing Zhao
2011-03-03 22:04 ` Bing Zhao
2011-03-03 22:40 ` Joe Perches
2011-03-04 0:35 ` Joe Perches
2011-03-04 0:59 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299139646.4338.69.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yangyang@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox