From: Joe Perches <joe@perches.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Marc Yang <yangyang@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: RE: [PATCH v2] mwifiex: remove PRINTM/HEXDUMP and associated
Date: Thu, 03 Mar 2011 12:10:58 -0800 [thread overview]
Message-ID: <1299183058.4338.148.camel@Joe-Laptop> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F704307F5150C5A@SC-VEXCH1.marvell.com>
On Thu, 2011-03-03 at 11:24 -0800, Bing Zhao wrote:
> For example, I can do "format 'mwifiex cmd' +p" and
> "format 'mwifiex event' +p" to enable debugging for "cmd" and "event" only.
Cute. That works.
Most similar current uses are a
integer bitmap equivalent.
echo bitmap_value > module_control_variable
if (module_control_variable & type)
print...
I think that's cleaner and less error prone
myself but opinions certainly vary.
> > Perhaps use use dev/netdev/wiphy_<level> where it makes
> > sense?
> I thought that too. But these APIs require a parameter of "struct device *".
> Some of mwifiex_ functions do not have this parameter.
Sure, but the places that do have an available
struct device|net_device|wiphy should use the
equivalent appropriate call.
cheers, Joe
next prev parent reply other threads:[~2011-03-03 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 22:31 [PATCH v2] mwifiex: remove PRINTM/HEXDUMP and associated Bing Zhao
2011-03-03 8:07 ` Joe Perches
2011-03-03 19:24 ` Bing Zhao
2011-03-03 20:10 ` Joe Perches [this message]
2011-03-03 20:58 ` Bing Zhao
2011-03-03 22:04 ` Bing Zhao
2011-03-03 22:40 ` Joe Perches
2011-03-04 0:35 ` Joe Perches
2011-03-04 0:59 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299183058.4338.148.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yangyang@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox